Make embed grid editor editable again #8576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nielslyngsoe I noticed you previous changed the scope property from |
|
@bjarnef I´m sorry but I don't recall this change, but I´m happy that you have found and fixed this issue. Thanks |
|
Yeah, it was changed here: bf9eeb4 The fix is quite simple, so it could probabaly be cherry picked for v8.6 or v8.7 since I guess v8.8 is first released in the autumn or at end of the year 🙂 |
|
Wonderful, that works! Will cherry-pick for 8.7! 👍 |
nul800sebastiaan
pushed a commit
that referenced
this pull request
Aug 26, 2020
(cherry picked from commit 2f69eac)
nul800sebastiaan
added
release/8.7.0
release/no-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #8575
Description
This PR fixes an issue where it was no longer possible to edit existing embed in grid editor as in PR #4899
After this was merged a few days later another PR #6341 was made to edit embed from TinyMCE editor. However this PR also changed the scope property in the infinite embed editor from
originaltomodifyin bf9eeb4 but wasn't aware it was passed in from embed grid editor.https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/editors/embed.controller.js#L25