Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add edit button #14

Closed
bjarnef opened this issue Dec 17, 2020 · 2 comments
Closed

Add edit button #14

bjarnef opened this issue Dec 17, 2020 · 2 comments
Labels
enhancement help wanted

Comments

@bjarnef
Copy link
Contributor

bjarnef commented Dec 17, 2020

It would be great to add a edit button to make it possible to adjust the embed url, but also the default width, height, etc.

I previous added this to the default Embed grid editor in this PR: umbraco/Umbraco-CMS#4899 and later some changes to make it work after again after some changes: umbraco/Umbraco-CMS#8576

Although the embed can just be removed and re-added, it might be an issue to content editors if they don't know the original url and it might not be easy to a non-technical person to find the url.
@dawoe
Copy link
Owner

dawoe commented Dec 17, 2020

Good idea @bjarnef

@bjarnef bjarnef mentioned this issue Jan 13, 2021
Merged
@dawoe
Copy link
Owner

dawoe commented Jan 22, 2021

Just released 4.3.0 that contains your pr.

@dawoe dawoe closed this as completed Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dawoe @bjarnef