Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite ancestor configurations for public access #17797

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Dec 12, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #17709

Description

See the linked issue for a description and steps to reproduce 😃

Testing this PR

Verify that:

  1. Public access can be added and updated in the structure below a protected document, without affecting the ancestor protection.
  2. Public access can be removed from the structure below a protected document, without affecting the ancestor protection.
  3. Public access can be removed from an ancestor document, without affecting any descendants with explicit public access configuration.

@Zeegaan Zeegaan merged commit c26b45d into release/15.1 Dec 12, 2024
28 of 29 checks passed
@Zeegaan Zeegaan deleted the v15/fix/17709-public-access-overwritten branch December 12, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants