Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Access - Child Node Permissions #17709

Closed
parxal opened this issue Dec 3, 2024 · 6 comments
Closed

Public Access - Child Node Permissions #17709

parxal opened this issue Dec 3, 2024 · 6 comments

Comments

@parxal
Copy link

parxal commented Dec 3, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.3.1

Bug summary

I have a parent node with several child nodes. The parent node has public access settings defined. Whenever I create a child node under this parent, it inherits the permissions from the parent.

Use case: I change the permissions of a single child node, and Umbraco applies this change to all the siblings and the parent node as well. Shouldn't the change affect only that specific child node?

Specifics

No response

Steps to reproduce

1 - Create a Node (Parent)
2 - Assign public access roles (Parent)
3 - Create a child Node
4 - Change public access roles (Child node)
5 - Check Parent Node Permissions. Will notice that parent public access permissions were changed.

Expected result / actual result

When I change the public access settings of a specific node, it should only apply to that node itself and not to its siblings or parent.


This item has been added to our backlog AB#46945

@parxal parxal added the type/bug label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Hi there @parxal!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@NguyenThuyLan
Copy link
Contributor

Hi @parxal , thank you for reporting this issue.
I was able to reproduce it on v14.3.1 and v15.1.0-rc
Looks like the API /umbraco/management/api/v1/document/{id}/public-access returns wrong data

@parxal
Copy link
Author

parxal commented Dec 6, 2024

@NguyenThuyLan Hi, do you know what's the priority to fix this issue?

@nielslyngsoe nielslyngsoe added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Dec 11, 2024
@kjac
Copy link
Contributor

kjac commented Dec 11, 2024

Hi @parxal,

Thanks for reporting this 👍 I'll have a look at the root cause this week, then I'll have more info.

@kjac
Copy link
Contributor

kjac commented Dec 12, 2024

Fixed in #17797

Zeegaan pushed a commit that referenced this issue Dec 12, 2024
* Don't overwrite ancestor configurations for public access (#17709)

* Fix spacings
@kjac
Copy link
Contributor

kjac commented Dec 12, 2024

Will be released in V15.1.1 soon 👍

@kjac kjac closed this as completed Dec 12, 2024
@iOvergaard iOvergaard removed state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks state/reproduced labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants