Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n updates #2657

Merged
merged 13 commits into from
Apr 10, 2024
Merged

i18n updates #2657

merged 13 commits into from
Apr 10, 2024

Conversation

Maxime-J
Copy link
Contributor

@Maxime-J Maxime-J commented Apr 8, 2024

Hi,

A few updates linked to localization:

  • Formatting logic in filter tag value was inverted: you probably want the value formatted when it's not a search, and conversely.
    (Filtering values are actually no longer properly exanded/translated into their full correct names, example: https://analytics.umami.is/share/LGazGOecbDtaIwDr/umami.is?country=US)
  • admin label appeared twice in messages.ts, it was well handled, apparently no visible issues in app, just a warning in language scripts.
  • New strings in lang files so that it's easily translatable by everyone.
  • Update fr-FR

Copy link

vercel bot commented Apr 8, 2024

@Maxime-J is attempting to deploy a commit to the umami-software Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@mikecao mikecao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikecao mikecao changed the base branch from master to dev April 10, 2024 17:59
@mikecao mikecao merged commit bfd795f into umami-software:dev Apr 10, 2024
0 of 5 checks passed
@Maxime-J Maxime-J deleted the i18n branch April 23, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants