-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do doctests test suites always need to depend on the library? #19
Comments
@RyanGlScott can you paste the output of And also |
Note: there is no need to depend on the library, as we should pass everything to ( |
Here's the full output of
And here's the contents of
|
My hunch is that |
@RyanGlScott is it so, when there isn't dependency on |
@RyanGlScott exactly. So we don't really depend on the library, but we depend on the fact it should be configured (not built!) I have to think about this. |
I cannot reproduce this. Which |
I've reproduced this with both 2.0 and 1.24. |
Make sure you're doing this from a completely clean build, since the presence of |
I see. I cannot reproduce it with GHC-8.0.2, but I can with GHC-8.2.1 |
|
The most likely reason why this only repros on GHC 8.2 is because GHC 8.2 is bundled with Cabal 2.0, which correctly generates separate |
FWIW, I also recall experiencing this issue (having the test suites build before the library after invoking |
@ezyang it should look into library specific I guess there's no other way ATM than adding intra-dependency. It's semantically wrong, OTOH |
Resolve #19 by adding a caveat to the README
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
For commercialhaskell/stackage#2663. Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
It seems that
doctests
test suites might always have an implicit dependency on the library being tested. I noticed this when doing the following:The culprit appears to be that the
doctests
test suite inparsers
lacks an explicit dependency on theparsers
library. If I add that, thencabal test doctests
works as expected.Currently, we advise users in the documentation to depend on the library in a
doctests
test suite only in the event that one usescbits
, but perhaps we should always be advising this?The text was updated successfully, but these errors were encountered: