Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctest 0.12 #2663

Closed
28 tasks
bergmark opened this issue Jul 26, 2017 · 15 comments
Closed
28 tasks

doctest 0.12 #2663

bergmark opened this issue Jul 26, 2017 · 15 comments

Comments

@bergmark
Copy link
Member

doctest-0.12.0 (Simon Hengel sol@typeful.net @sol) is out of bounds for:

@decentral1se
Copy link
Member

FYI, there is no accompanying upper bound commit linked because we're trying to remove them all for the upcoming GHC-8.2.1 release (work in progress over at 5cdd7df).

@RyanGlScott
Copy link
Contributor

I'll update the Kmettiverse packages once there's a resolution on ulidtko/cabal-doctest#19.

@quchen
Copy link
Contributor

quchen commented Jul 27, 2017

  • prettyprinter-1.1 fixed by Hackage revision

snoyberg added a commit that referenced this issue Jul 27, 2017
@Gabriella439
Copy link
Contributor

Fixed in pipes-group-1.0.7 and turtle-1.4.0

tfausak added a commit to tfausak/flow that referenced this issue Jul 28, 2017
RyanGlScott added a commit to ekmett/semigroupoids that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/linear that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/trifecta that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/zippers that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/rcu that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/lens that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/machines that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/linear-accelerate that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/log-domain that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to lens/lens-aeson that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/intervals that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/heaps that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/distributive that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/comonad that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/bound that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
RyanGlScott added a commit to ekmett/ad that referenced this issue Jul 28, 2017
For commercialhaskell/stackage#2663.

Also, add a library dependency in the test suite to work around ulidtko/cabal-doctest#19.
@RyanGlScott
Copy link
Contributor

An update: I've uploaded versions of the following packages to Hackage that support doctest-0.12:

  • ad
  • bits
  • bound
  • bytes
  • comonad
  • distributive
  • intervals
  • lens-aeson
  • linear
  • linear-accelerate
  • log-domain
  • semigroupoids
  • zippers

That is, every Kmettiverse package except lens. I've decided not to upload a new version of lens yet since there have been some difficulties upgrading lens to doctest-0.12 which haven't been fully resolved yet: ekmett/lens#756

@joneshf
Copy link
Contributor

joneshf commented Jul 30, 2017

Fixed for servant-ruby with 0.3.0.0.

@sol
Copy link
Contributor

sol commented Aug 1, 2017

@bergmark I deprecated 0.12.0 on Hackage. I recommend that you use < 0.12.0 for Stackage until sol/doctest#170 is resolved. There will be a 0.13.0 release later on.

@bergmark
Copy link
Member Author

bergmark commented Aug 2, 2017

@sol is it possible to release a fix in the 0.12.x series? It would save maintainers some, or in Ryan's case a lot of, effort :)

@sol
Copy link
Contributor

sol commented Aug 2, 2017

@bergmark 0.13.0 will introduce a breaking change vs. 0.12.0 so it has to be a major version bump. I'm sorry if that causes additional work for anybody.

@RyanGlScott
Copy link
Contributor

Upgrading to 0.13 will be significantly easier for me, luckily. For 0.12, I had to release new versions of each package to work around an unrelated problem in the way we were using cabal-doctest, but from now on I can manage with simple Hackage revisions.

@sol
Copy link
Contributor

sol commented Aug 2, 2017

@bergmark To clarify, there is no workaround for this bug, as it is a GHC bug. The only way I'm aware of to prevent it is to change the behavior of doctest in a backward-incompatible manner.

@sol
Copy link
Contributor

sol commented Aug 3, 2017

doctest-0.13.0 is on Hackage.

RyanGlScott added a commit to ekmett/lens that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/ad that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/bits that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/bound that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/bytes that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/comonad that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/distributive that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/heaps that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/hyphenation that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/intervals that referenced this issue Aug 3, 2017
RyanGlScott added a commit to lens/lens-aeson that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/log-domain that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/linear that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/linear-accelerate that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/machines that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/rcu that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/semigroupoids that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/trifecta that referenced this issue Aug 3, 2017
RyanGlScott added a commit to ekmett/zippers that referenced this issue Aug 3, 2017
tfausak added a commit to tfausak/flow that referenced this issue Aug 3, 2017
@RyanGlScott
Copy link
Contributor

All of the packages in #2663 (comment), as well as lens, now support doctest-0.13.

@Porges
Copy link
Contributor

Porges commented Aug 3, 2017

Since I'm pretty new around here: do I need to send a PR for unblocking myself or does that magically happen?

@snoyberg
Copy link
Contributor

snoyberg commented Aug 4, 2017

@Porges A PR to unblock is much more reliable, I'd definitely recommend it.

@DanBurton DanBurton mentioned this issue Aug 29, 2017
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants