Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crash when using clm lake and GFS PBL/sfclay #2056

Closed
wants to merge 7 commits into from
Closed

fix crash when using clm lake and GFS PBL/sfclay #2056

wants to merge 7 commits into from

Conversation

JiliDong-NOAA
Copy link
Contributor

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Hercules AND have attached the log to this PR below this line:
    • LOG:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

This PR is to fix the RRFS ensemble member crash when combining clm lake and GFS PBL/sfclay:

#2055

A new flag is created to track new freezing lake ice and let sfc_diff to calculate stability variables over the new icy grids for GFS PBL in the second surface loop, which otherwise will remain as missing values.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

#2055

Subcomponent Pull Requests

NOAA-EMC/fv3atm#742
NOAA-EMC/CMEPS#105
ufs-community/ccpp-physics#148

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@JiliDong-NOAA
Copy link
Contributor Author

@SamuelTrahanNOAA I have the PR here to fix the crash when using clm lake and GFS PBL/sfclay in RRFS ensemble. No RT baseline changes expected. Could this PR be combined with your clm lake bug fix PR if time/schedule permits?

@SamuelTrahanNOAA
Copy link
Collaborator

I have the PR here to fix the crash when using clm lake and GFS PBL/sfclay in RRFS ensemble. No RT baseline changes expected. Could this PR be combined with your clm lake bug fix PR if time/schedule permits?

Have you run the regression tests to ensure the baselines do not change?

@SamuelTrahanNOAA
Copy link
Collaborator

@jkbk2004 - Do you approve of combining this with the other CLM Lake pull request (#2044)? This PR is as urgent as that one and fixes the other half of the CLM Lake troubles.

@JiliDong-NOAA
Copy link
Contributor Author

I have the PR here to fix the crash when using clm lake and GFS PBL/sfclay in RRFS ensemble. No RT baseline changes expected. Could this PR be combined with your clm lake bug fix PR if time/schedule permits?

Have you run the regression tests to ensure the baselines do not change?

Yes, I did run full RT on Hera. Just have RT log uploaded.

RegressionTests_hera.log

@SamuelTrahanNOAA
Copy link
Collaborator

Yes, I did run full RT on Hera. Just have RT log uploaded.

Excellent. Once @jkbk2004 says it's okay, I will combine the three PRs into one.

@JiliDong-NOAA
Copy link
Contributor Author

Yes, I did run full RT on Hera. Just have RT log uploaded.

Excellent. Once @jkbk2004 says it's okay, I will combine the three PRs into one.

Thanks @SamuelTrahanNOAA . Now I will change the new flag name as Jun suggested in all submodules.

NOAA-EMC/CMEPS#105 (review)

@JiliDong-NOAA
Copy link
Contributor Author

Yes, I did run full RT on Hera. Just have RT log uploaded.

Excellent. Once @jkbk2004 says it's okay, I will combine the three PRs into one.

Thanks @SamuelTrahanNOAA . Now I will change the new flag name as Jun suggested in all submodules.

NOAA-EMC/CMEPS#105 (review)

flag name change done.

@SamuelTrahanNOAA
Copy link
Collaborator

@JiliDong-NOAA - Please let me know when this PR is in its final form. The combined PR is scheduled for testing tomorrow. If you take too long, I won't be able to combine them in time.

@SamuelTrahanNOAA
Copy link
Collaborator

The FV3 submodule has doesn't match the hash of NOAA-EMC/fv3atm#742

FV3 submodule hash = 1e814d6e1ed9d17b6461461e081d99693f426ae3
NOAA-EMC/fv3atm#742 PR branch hash = beb11529977c30963fe6f583f214134efdbf7579

@JiliDong-NOAA
Copy link
Contributor Author

@JiliDong-NOAA - Please let me know when this PR is in its final form. The combined PR is scheduled for testing tomorrow. If you take too long, I won't be able to combine them in time.

I think it is ready for combining. I have synced with the latest develop and addressed all reviewers' comments.

@JiliDong-NOAA
Copy link
Contributor Author

JiliDong-NOAA commented Dec 19, 2023 •
edited
Loading

The FV3 submodule has doesn't match the hash of NOAA-EMC/fv3atm#742

FV3 submodule hash = 1e814d6e1ed9d17b6461461e081d99693f426ae3 NOAA-EMC/fv3atm#742 PR branch hash = beb11529977c30963fe6f583f214134efdbf7579

Could you double check? I have updated FV3 12 minutes ago.

snapshot

@SamuelTrahanNOAA SamuelTrahanNOAA mentioned this pull request Dec 19, 2023
Merged
35 tasks
SamuelTrahanNOAA added a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Dec 19, 2023
@SamuelTrahanNOAA
merge ufs-community#2056
c330e79
@SamuelTrahanNOAA
Copy link
Collaborator

I've merged all components into #2044. It should be correct in that branch.

@JiliDong-NOAA
Copy link
Contributor Author

I've merged all components into #2044. It should be correct in that branch.

Thanks @SamuelTrahanNOAA !

zach1221 pushed a commit that referenced this pull request Dec 21, 2023
@SamuelTrahanNOAA
CLM Lake pressure is not density and GFS Diagnostics: weasdi is not s…
991d652 
…nodi + #2047, #2053, and #2056 (#2044)

FV3 diagnostic fixes, CCPP fixes for model crashes, new PR template

- UFS:
    - commit message in PR template (#2053)
    - fix hercules crashes (#2015)
- CMEPS & FV3: Bad data from in CCPP CLM Lake physics scheme caused model crashes
    - Communicate changes to lake ice (Closes #2055, NOAA-EMC/CMEPS#105, NOAA-EMC/fv3atm#741) 
    - unit mismatch (NOAA-EMC/fv3atm#736)
- FV3: correct errors in diagnostic calculations
    - snodi had weasdi data in it (NOAA-EMC/fv3atm#736)
    - revisions to RUC LSM snowfall melting and accumulation (NOAA-EMC/fv3atm#739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiliDong-NOAA @SamuelTrahanNOAA