Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revisions to snowfall melting and accumulation from @tanyasmirnova #2047

Closed
wants to merge 4 commits into from
Closed

revisions to snowfall melting and accumulation from @tanyasmirnova #2047

wants to merge 4 commits into from

Conversation

SamuelTrahanNOAA
Copy link
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA commented Dec 18, 2023 •
edited
Loading

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Hercules AND have attached the log to this PR below this line:
    • LOG: committed to branch
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

This is an urgent minor change to RUC LSM from @tanyasmirnova.

This includes:

  1. A change in the diagnostic of the snow depth accumulation. The old diagnostic included snow melting, but in the new version it includes only the snow fall with variable density. This was decided after consultations with people from the Weather Service.
  2. The old diagnostics that included snow melting in the computation of snowfallacc had a bug in the computation of snow melt. Snow melt and snow sublimation should not be multiplied by snowfrac. It is also only the diagnostic variables.
  3. The change to uncomment snow_mosaic=0 for fresh snow changes the model performance. This will help RRFS with the deficient snow depth on the ground.

All changes are in FV3/ccpp/physics.

Commit Message

Linked Issues and Pull Requests

Associated UFSWM Issue to close

None.

Subcomponent Pull Requests

Blocking Dependencies

None.

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.

Regression Tests:

  • Changes are expected to the following tests:

All tests that use RUC LSM.

List of tests in rt.conf format 
COMPILE | rrfs | intel | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_RAP_sfcdiff,FV3_HRRR,FV3_RRFS_v1beta,FV3_RRFS_v1nssl -D32BIT=ON | | fv3 |
RUN | rap_control                                       |                            | baseline |
RUN | regional_spp_sppt_shum_skeb                       |                            | baseline |
RUN | rap_decomp                                        | - noaacloud                |          |
RUN | rap_2threads                                      | - derecho noaacloud        |          |
RUN | rap_restart                                       | - noaacloud                |          | rap_control
RUN | rap_sfcdiff                                       | - noaacloud                | baseline |
RUN | rap_sfcdiff_decomp                                | - noaacloud                |          |
RUN | rap_sfcdiff_restart                               | - noaacloud                |          | rap_sfcdiff
RUN | hrrr_control                                      | - noaacloud                | baseline |
RUN | hrrr_control_decomp                               | - noaacloud                |          |
RUN | hrrr_control_2threads                             | - noaacloud                |          |
RUN | hrrr_control_restart                              | - noaacloud                |          | hrrr_control
COMPILE | atm_debug_dyn32 | intel | -DAPP=ATM -DDEBUG=ON -D32BIT=ON -DCCPP_SUITES=FV3_HRRR,FV3_GFS_v16,FV3_GFS_v16_csawmg,FV3_GFS_v16_ras,FV3_GFS_v17_p8,FV3_GFS_v15_thompson_mynn_lam3km,FV3_RAP,FV3_RAP_unified_ugwp,FV3_RAP_cires_ugwp,FV3_RAP_flake,FV3_RAP_clm_lake,FV3_RAP_noah,FV3_RAP_sfcdiff,FV3_RAP_noah_sfcdiff_cires_ugwp,FV3_RRFS_v1beta,FV3_HRRR_c3,FV3_HRRR_gf,FV3_global_nest_v1 | - noaacloud  | fv3 |
RUN | rap_control_debug                                 | - noaacloud                  | baseline |
RUN | hrrr_control_debug                                | - noaacloud                  | baseline |
RUN | hrrr_gf_debug                                     | - noaacloud                  | baseline |
RUN | hrrr_c3_debug                                     | - noaacloud                  | baseline |
RUN | rap_unified_drag_suite_debug                      | - noaacloud                  |          |
RUN | rap_diag_debug                                    | - noaacloud                  | baseline |
RUN | rap_cires_ugwp_debug                              | - noaacloud                  | baseline |
RUN | rap_unified_ugwp_debug                            | - noaacloud                  |          |
RUN | rap_lndp_debug                                    | - noaacloud                  | baseline |
RUN | rap_progcld_thompson_debug                        | - noaacloud                  | baseline |
RUN | rap_sfcdiff_debug                                 | - noaacloud                  | baseline |
RUN | rap_clm_lake_debug                                | - noaacloud                  | baseline |
RUN | rap_flake_debug                                   | - noaacloud                  | baseline |
COMPILE | wam_debug | intel | -DAPP=ATM -DCCPP_SUITES=FV3_GFS_v16_fv3wam -D32BIT=ON -DMULTI_GASES=ON -DDEBUG=ON | - noaacloud  | fv3 |
RUN | control_wam_debug                                 | - noaacloud hercules         | baseline |
COMPILE | rrfs_dyn32_phy32 | intel | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_HRRR -D32BIT=ON -DCCPP_32BIT=ON |  - noaacloud  | fv3 |
RUN | regional_spp_sppt_shum_skeb_dyn32_phy32           | - noaacloud                  | baseline |
RUN | rap_control_dyn32_phy32                           | - noaacloud                  | baseline |
RUN | hrrr_control_dyn32_phy32                          | - noaacloud                  | baseline |
RUN | rap_2threads_dyn32_phy32                          | - derecho noaacloud          |          |
RUN | hrrr_control_2threads_dyn32_phy32                 | - derecho noaacloud          |          |
RUN | hrrr_control_decomp_dyn32_phy32                   | - noaacloud                  |          |
RUN | rap_restart_dyn32_phy32                           | - noaacloud                  |          | rap_control_dyn32_phy32
RUN | hrrr_control_restart_dyn32_phy32                  | - noaacloud                  |          | hrrr_control_dyn32_phy32
COMPILE | rrfs_dyn32_phy32_faster | intel | -DAPP=ATM -DFASTER=ON -DCCPP_SUITES=FV3_HRRR -D32BIT=ON -DCCPP_32BIT=ON | - noaacloud  | fv3 |
RUN | conus13km_control             | - noaacloud                                      | baseline |
RUN | conus13km_2threads            | - noaacloud                                      |          | conus13km_control
RUN | conus13km_restart_mismatch    | - noaacloud                                      | baseline | conus13km_control
# RUN | conus13km_restart           | - noaacloud                                      |          | conus13km_control
# RUN | conus13km_decomp            | - noaacloud                                      |          | conus13km_control
COMPILE | rrfs_dyn64_phy32 | intel | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_HRRR -DCCPP_32BIT=ON | - noaacloud  | fv3 |
RUN | rap_control_dyn64_phy32                           |  - noaacloud                 | baseline |
COMPILE | rrfs | gnu | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_RAP_sfcdiff,FV3_HRRR,FV3_RRFS_v1beta -D32BIT=ON | + hera hercules | fv3 |
RUN | rap_control                                       | + hera hercules            | baseline |
RUN | rap_decomp                                        | + hera hercules            |          |
RUN | rap_2threads                                      | + hera hercules            |          |
RUN | rap_restart                                       | + hera hercules            |          | rap_control
RUN | rap_sfcdiff                                       | + hera hercules            | baseline |
RUN | rap_sfcdiff_decomp                                | + hera hercules            |          |
RUN | rap_sfcdiff_restart                               | + hera hercules            |          | rap_sfcdiff
RUN | hrrr_control                                      | + hera hercules            | baseline |
RUN | hrrr_control_noqr                                 | + hera hercules            |          |
RUN | hrrr_control_2threads                             | + hera hercules            |          |
RUN | hrrr_control_decomp                               | + hera hercules            |          |
RUN | hrrr_control_restart                              | + hera hercules            |          | hrrr_control
RUN | hrrr_control_restart_noqr                         | + hera hercules            |          | hrrr_control_noqr
COMPILE | atm_dyn32_debug | gnu | -DAPP=ATM -D32BIT=ON -DDEBUG=ON | + hera hercules | fv3 |
RUN | rap_control_debug                                 | + hera hercules            | baseline |
RUN | hrrr_control_debug                                | + hera hercules            | baseline |
RUN | hrrr_gf_debug                                     | + hera hercules            | baseline |
RUN | hrrr_c3_debug                                     | + hera hercules            | baseline |
RUN | rap_diag_debug                                    | + hera hercules            | baseline |
RUN | rap_progcld_thompson_debug                        | + hera hercules            | baseline |
RUN | rap_flake_debug                                   | + hera hercules            | baseline |
RUN | rap_clm_lake_debug                                | + hera hercules            | baseline |
COMPILE | wam_debug | gnu | -DAPP=ATM -DCCPP_SUITES=FV3_GFS_v16_fv3wam -D32BIT=ON -DMULTI_GASES=ON -DDEBUG=ON | + hera hercules | fv3 |
RUN | control_wam_debug                                 | + hera                     | baseline |
COMPILE | rrfs_dyn32_phy32 | gnu | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_HRRR -D32BIT=ON -DCCPP_32BIT=ON | + hera hercules | fv3 |
RUN | rap_control_dyn32_phy32                           | + hera hercules            | baseline |
RUN | hrrr_control_dyn32_phy32                          | + hera hercules            | baseline |
RUN | rap_2threads_dyn32_phy32                          | + hera hercules            |          |
RUN | hrrr_control_2threads_dyn32_phy32                 | + hera hercules            |          |
RUN | hrrr_control_decomp_dyn32_phy32                   | + hera hercules            |          |
RUN | rap_restart_dyn32_phy32                           | + hera hercules            |          | rap_control_dyn32_phy32
RUN | hrrr_control_restart_dyn32_phy32                  | + hera hercules            |          | hrrr_control_dyn32_phy32
RUN | conus13km_control                                 | + hera hercules            | baseline |
RUN | conus13km_2threads                                | + hera hercules            |          | conus13km_control
RUN | conus13km_restart_mismatch                        | + hera hercules            | baseline | conus13km_control
# RUN | conus13km_restart                               | + hera hercules            |          | conus13km_control
# RUN | conus13km_decomp                                | + hera hercules            |          | conus13km_control
COMPILE | atm_dyn64_phy32 | gnu | -DAPP=ATM -DCCPP_32BIT=ON | + hera hercules | fv3 |
RUN | rap_control_dyn64_phy32                           | + hera hercules            | baseline |
COMPILE | atm_dyn32_phy32_debug | gnu | -DAPP=ATM -D32BIT=ON -DCCPP_32BIT=ON -DDEBUG=ON | + hera hercules | fv3 |
RUN | rap_control_debug_dyn32_phy32                     | + hera hercules            | baseline |
RUN | hrrr_control_debug_dyn32_phy32                    | + hera hercules            | baseline |
RUN | conus13km_debug                                   | + hera hercules            | baseline |
RUN | conus13km_debug_qr                                | + hera hercules            |          |
RUN | conus13km_debug_2threads                          | + hera hercules            |          |
RUN | conus13km_radar_tten_debug                        | + hera hercules            | baseline |
# RUN | conus13km_debug_decomp       | + hera derecho hercules            |          |
COMPILE | atm_dyn64_phy32_debug | gnu | -DAPP=ATM -DCCPP_32BIT=ON -DDEBUG=ON | + hera hercules | fv3 |
RUN | rap_control_dyn64_phy32_debug                     | + hera hercules            | baseline |

Libraries

  • Not Needed
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@SamuelTrahanNOAA SamuelTrahanNOAA mentioned this pull request Dec 18, 2023
Merged
35 tasks
@SamuelTrahanNOAA SamuelTrahanNOAA changed the title revisions to slowfall melting and accumulation from @tanyasmirnova revisions to snowfall melting and accumulation from @tanyasmirnova Dec 18, 2023
@DeniseWorthen
Copy link
Collaborator

@SamuelTrahanNOAA We're adding a commit message to the PR templates and I'm manually adding it to current/pending PRs. Please add in the space provided. Thanks.

SamuelTrahanNOAA added a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Dec 19, 2023
@SamuelTrahanNOAA
merge ufs-community#2047
24236dc
zach1221 pushed a commit that referenced this pull request Dec 21, 2023
@SamuelTrahanNOAA
CLM Lake pressure is not density and GFS Diagnostics: weasdi is not s…
991d652 
…nodi + #2047, #2053, and #2056 (#2044)

FV3 diagnostic fixes, CCPP fixes for model crashes, new PR template

- UFS:
    - commit message in PR template (#2053)
    - fix hercules crashes (#2015)
- CMEPS & FV3: Bad data from in CCPP CLM Lake physics scheme caused model crashes
    - Communicate changes to lake ice (Closes #2055, NOAA-EMC/CMEPS#105, NOAA-EMC/fv3atm#741) 
    - unit mismatch (NOAA-EMC/fv3atm#736)
- FV3: correct errors in diagnostic calculations
    - snodi had weasdi data in it (NOAA-EMC/fv3atm#736)
    - revisions to RUC LSM snowfall melting and accumulation (NOAA-EMC/fv3atm#739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanyasmirnova tanyasmirnova tanyasmirnova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamuelTrahanNOAA @DeniseWorthen @tanyasmirnova