Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new ccpp SDFs added to support RRFS multiphysics ensemble and add tob in ocean output (#2019) #1997

Closed
wants to merge 6 commits into from
Closed

new ccpp SDFs added to support RRFS multiphysics ensemble and add tob in ocean output (#2019) #1997

wants to merge 6 commits into from

Conversation

JiliDong-NOAA
Copy link
Contributor

@JiliDong-NOAA JiliDong-NOAA commented Nov 14, 2023 •
edited by BrianCurtis-NOAA
Loading

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

A decision has been made for RRFS ensemble to apply a multiphysics approach. Five new ccpp SDFs are added in support of the RRFS ensemble development.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

NOAA-EMC/fv3atm#721

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@BrianCurtis-NOAA BrianCurtis-NOAA added No Baseline Change No Baseline Change Waiting for Reviews The PR is waiting for reviews from associated component PR's. Incomplete This PR does not have all required information. Please see PR Author checklist. labels Nov 17, 2023
@JiliDong-NOAA JiliDong-NOAA mentioned this pull request Nov 17, 2023
Closed
@JiliDong-NOAA
Copy link
Contributor Author

JiliDong-NOAA commented Nov 20, 2023 •
edited
Loading

RegressionTests_hera.log
attached RT log on Hera

@JiliDong-NOAA
Copy link
Contributor Author

RT log updated
RegressionTests_hera.log

@jkbk2004 jkbk2004 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. and removed Incomplete This PR does not have all required information. Please see PR Author checklist. Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Nov 30, 2023
@zach1221
Copy link
Collaborator

Hi, @JiliDong-NOAA . Can you sync up your branch, please?

@JiliDong-NOAA
Copy link
Contributor Author

Hi, @JiliDong-NOAA . Can you sync up your branch, please?

Done.

@jiandewang jiandewang mentioned this pull request Dec 1, 2023
Closed
@JiliDong-NOAA
Copy link
Contributor Author

another minor change by adding one variable in ocean output to diag_table (from @jiandewang). No changes on RT as shown in the latest Hera log
RegressionTests_hera.log

@JiliDong-NOAA JiliDong-NOAA changed the title new ccpp SDFs added to support RRFS multiphysics ensemble new ccpp SDFs added to support RRFS multiphysics ensemble and add tob in ocean output (#2019) Dec 1, 2023
@ulmononian ulmononian mentioned this pull request Dec 1, 2023
Merged
36 tasks
zach1221 pushed a commit that referenced this pull request Dec 4, 2023
@ulmononian
Add support for Gaea C5 (includes PR #1977: new ccpp SDFs added to su…
f42e347 
…pport RRFS multiphysics ensemble and add tob in ocean output)(Includes PR #1997) (#1784)

* Reinstate all the c5 changes that I botched with my git ignorance.

* Update ufs_common. Upate c5 modulefile.

* TPN adjustments for C5 regional_atmaq tests.

* Remove set -eu from module-setup.sh

* Update rt.sh adding new DISKNM for Gaea_C5

* updates for gaea-c5 modulefiles, scripts

* Update rt.conf fix gaea machine name
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Dec 4, 2023

merged with #1784

@jkbk2004 jkbk2004 closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JiliDong-NOAA @zach1221 @jkbk2004 @BrianCurtis-NOAA