Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 5 ccpp SDFs in support of RRFS multiphysics ensemble #721

Merged
merged 7 commits into from
Dec 4, 2023

Conversation

JiliDong-NOAA
Copy link
Contributor

@JiliDong-NOAA JiliDong-NOAA commented Nov 14, 2023

Description

A decision has been made for RRFS ensemble to apply a multiphysics approach. Five new ccpp SDFs are added in support of the RRFS multiphysics ensemble development.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

None

@JiliDong-NOAA JiliDong-NOAA changed the title add 5 ccpp SDFs in support of RRFS ensemble add 5 ccpp SDFs in support of RRFS multiphysics ensemble Nov 14, 2023
@JiliDong-NOAA
Copy link
Contributor Author

JiliDong-NOAA commented Nov 16, 2023

is there anything I can do to move this PR forward?

@JiliDong-NOAA
Copy link
Contributor Author

these new ccpp suites are needed for RRFS ensemble and the RRFS code freeze deadline is Dec 1. could we get any comment/review for this PR? thanks @junwang-noaa @BrianCurtis-NOAA @DusanJovic-NOAA

@MatthewPyle-NOAA
Copy link
Collaborator

Thanks for approving, @DusanJovic-NOAA. Are you okay with it @BrianCurtis-NOAA ? As Jili noted above, we'd like to wrap this one up fairly soon. Thanks!

@JiliDong-NOAA
Copy link
Contributor Author

one more ccpp SDF is added to support RRFS fire weather application from @BenjaminBlake-NOAA by removing GWD in FV3_HRRR_gf

@zach1221
Copy link
Collaborator

zach1221 commented Dec 4, 2023

@jkbk2004 Regression testing is complete on UFS-WM PR #1784 . Please feel free to merge this FV3ATM sub-PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants