Fix RAP (Grell Freitas) decomp b4b issues, enable tests in rt.conf/rt_gnu.conf
#1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
added
Baseline Updates
This was referenced Jun 6, 2022
|
@junwang-noaa Please add reviewers from EPIC as appropriate, thanks! |
This was referenced Jun 10, 2022
|
Replaced by #1257. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Description
Update submodule pointer for fv3atm and ccpp-physics for the changes described in NCAR/ccpp-physics#933. This fixes the RAP (Grell Freitas) decomp b4b issues. Enable the corresponding tests in
rt.confandrt_gnu.conf.I tested these changes on Hera with Intel and GNU, and for both the
rap_decomptest now reproduces against therap_controltest.Because of the bug fix in
cu_gf_deep.F90(see details in NCAR/ccpp-physics#933), results for all regression tests using GF change.Issue(s) addressed
Testing
I ran a subset of
rt.confandrt_gnu.conf(all RAP tests, a few HRRR/RRFS tests) on Hera with Intel and GNU (first create new baseline, then verify against it), all tests passed.rt_rap_decomp_gnu_create.log
rt_rap_decomp_gnu_verify.log
rt_rap_decomp_intel_create.log
rt_rap_decomp_intel_verify.log
Full regression tests will be run on all platforms at the time of commit (new baselines required).
Dependencies