Fix RAP (Grell Freitas) decomp b4b issues #933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for-bit identical decomp results with GF
climbfuji
changed the title
climbfuji
changed the title
This was referenced Jun 6, 2022
climbfuji
requested review from
hannahcbarnes,
haiqinli,
SamuelTrahanNOAA,
grantfirl,
mzhangw,
panll,
mkavulich and
ChunxiZhang-NOAA
as code owners
climbfuji
commented
Jun 6, 2022
| @@ -27,7 +27,7 @@ module cu_gf_deep | |||
| !> flag to turn off or modify mom transport by downdrafts | |||
| real(kind=kind_phys), parameter :: pgcd = 0.1 | |||
| ! | |||
| !> aerosol awareness, do not user yet! | |||
| !> aerosol awareness, do not use yet! | |||
There was a problem hiding this comment.
Since this code is obviously used, should we remove the comment?
There was a problem hiding this comment.
That works for me. It has a small impact right now.
climbfuji
commented
Jun 6, 2022
| deriv3 = deriv3 + 2.0*f(3)/((x(3)-x(1))*(x(3)-x(2))) | ||
| end if | ||
| end function deriv3 | ||
| ! DH* 20220604 - this isn't used at all |
There was a problem hiding this comment.
Should we remove this entire function deriv3, since it isn't used?
There was a problem hiding this comment.
I think this is ok. @haiqinli do you agree? Is there any reason why we need to keep deriv3 in the code? Is there a direct way we plan of using in the future?
There was a problem hiding this comment.
@hannahcbarnes @climbfuji We don't have plan to use it in the future. It should be ok to remove this function.
ChunxiZhang-NOAA
approved these changes
Jun 10, 2022
This was referenced Jun 10, 2022
|
Replaced by #942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes in
physics/cu_gf_deep.F90andphysics/cu_gf_driver.F90for bit-for-bit identical results with GF when changing the MPI decomposition. Instead of using thepefcvalue of last column (pefcwas a scalar), which is incorrect, turnpefcinto a vector of lengthhorizontal_loop_extentand use the correct value in GF deep convection.Minor formatting cleanup in removal of unused symbols/code.
Associated PRs:
NOAA-EMC/fv3atm#543
ufs-community/ufs-weather-model#1243
For regression testing, see ufs-community/ufs-weather-model#1243