Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a regression test that uses a different fhzero interval. #583

Closed
climbfuji opened this issue May 17, 2021 · 0 comments · Fixed by #691
Closed

Add a regression test that uses a different fhzero interval. #583

climbfuji opened this issue May 17, 2021 · 0 comments · Fixed by #691
Labels
enhancement New feature or request

Comments

@climbfuji
Copy link
Collaborator

Description

@mdtoyNOAA noticed that for UGWP v1 the results change if fhzero is changed. This is currently not the case for any other scheme, as far as we know, but it would be good to test this for the new GFS v16 control in the future.

Solution

Add a test similar to fv3_gfsv16_2threads that does nothing but changing fhzero from 6h to 3h.

Alternatives

Modify an existing test such as fv3_gfsv16_2threads to use fhzero = 3 instead if 6. I don't advise doing this. It saves one test, but if the test fails it can be because of two reasons.
@climbfuji climbfuji added the enhancement New feature or request label May 17, 2021
@junwang-noaa junwang-noaa mentioned this issue Jul 15, 2021
Merged
11 tasks
epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
@JeffBeck-NOAA
Fixes to the "pazi" parameter to work with both GFDL and ESG grids. (#…
d7c0f06 
…583)
epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
@mkavulich
[develop] Fix failing unit test due to renamed variable (#583)
844f347 
PR #566 changed the variable "MODEL" to a more descriptive name, but failed to make this change in config.community.yaml. The unit tests for generate_FV3LAM_wflow.py make use of this file as an input config.yaml, so they are now failing due to this incorrect variable name. This wasn't caught because prior to #558 the unit tests were broken for a different reason.

This change simply makes the appropriate rename, which should fix the failing unit test. Also created an f-string that was missed in a setup.py error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@climbfuji