Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CI triggering method #558

Closed
MinsukJi-NOAA opened this issue May 5, 2021 · 1 comment
Closed

Change CI triggering method #558

MinsukJi-NOAA opened this issue May 5, 2021 · 1 comment
Assignees
@MinsukJi-NOAA
Labels
enhancement New feature or request

Comments

@MinsukJi-NOAA
Copy link
Contributor

MinsukJi-NOAA commented May 5, 2021 •
edited
Loading

Description

Based on recent experiences, it is found to be inconvenient to have to specify "run-ci" in the commit message in order to trigger the CI

Solution

Change so that CI is triggered by "run-ci" label instead
@MinsukJi-NOAA MinsukJi-NOAA added the enhancement New feature or request label May 5, 2021
@MinsukJi-NOAA MinsukJi-NOAA self-assigned this May 5, 2021
MinsukJi-NOAA added a commit to MinsukJi-NOAA/ufs-weather-model that referenced this issue May 12, 2021
@MinsukJi-NOAA
Change CI triggering method ufs-community#558
15cd9d4 
* CI runs when run-ci label is created
* Old method of specifying run-ci in commit message is obsolete
* Push event no longer triggers the CI
* Minor fixes in aux.yml
@MinsukJi-NOAA MinsukJi-NOAA mentioned this issue May 12, 2021
Closed
13 tasks
climbfuji added a commit that referenced this issue May 18, 2021
@climbfuji @MinsukJi-NOAA
@binli2337 @BrianCurtis-NOAA @DeniseWorthen
Rename CCPP branches from master to main, several small changes in cc…
19e49ec 
…pp-physics (#572)

* Change CI triggering method #558: CI runs when run-ci label is created
* Remove FMS remnant from compile.sh
* Move load cmake call to after hpc-stack on wcoss_dell_p3
* CDEPS updates

Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov>
Co-authored-by: Bin Li <bin.li@noaa.gov>
Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
Co-authored-by: denise.worthen <Denise.Worthen@noaa.gov>
@MinsukJi-NOAA
Copy link
Contributor Author

This issue is resolved by code changes in #572

pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this issue Apr 4, 2023
@WenMeng-NOAA
Update upp submodule for fixing in-line post issues for RRFS and HAFS (…
b9d61f2 
…ufs-community#558)

* update upp revision to 8767929

* modify dx/dy calculation for RRFS with domain over north pole
epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
@chan-hoo
Remove domains_stack_size from input.yml (#558)
178d375
epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
@mkavulich
[develop] First implementation of run_WE2E_tests.py (#558)
7299fef 
This PR introduces two new scripts to the repository: run_WE2E_tests.py and monitor_jobs.py. The purpose of these scripts is to eventually provide a pythonic replacement for the current workflow end-to-end test submission script. Additionally, the monitor_jobs function gives the capability to monitor and submit jobs automatically via the command line or a batch job, rather than relying on crontab entries.
epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
@mkavulich
[develop] Fix failing unit test due to renamed variable (#583)
844f347 
PR #566 changed the variable "MODEL" to a more descriptive name, but failed to make this change in config.community.yaml. The unit tests for generate_FV3LAM_wflow.py make use of this file as an input config.yaml, so they are now failing due to this incorrect variable name. This wasn't caught because prior to #558 the unit tests were broken for a different reason.

This change simply makes the appropriate rename, which should fix the failing unit test. Also created an f-string that was missed in a setup.py error message.
epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
@mkavulich
[develop] Replace shell-based WE2E scripts with python versions (#637)
d917ace 
This PR improves on the new ./run_WE2E_tests.py script (introduced in #558), implementing all the features present in the previous shell-based workflow. Some new files are also introduced for better organization and additional functionality:

* tests/WE2E/utils.py This is a collection of functions used by other scripts, contained here to avoid circular dependencies.
* tests/WE2E/WE2E_summary.py Given an experiment directory or .yaml file, outputs a summary to screen of each experiment, its status, and the number of core hours used. It also prints a summary file with detailed information about each task for each experiment.
* tests/WE2E/print_test_info.py Will print a file WE2E_test_info.txt, very similar to the legacy WE2E_test_info.csv with just a few minor format differences.

Any scripts can be run with the -h argument to print information about all available options (not including utils.py, which is not designed to be run stand-alone).

With this PR, the old superseded shell-based tools are removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MinsukJi-NOAA MinsukJi-NOAA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MinsukJi-NOAA