Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Integrate Unified Workflow tool set_config #830

Conversation

christinaholtNOAA
Copy link
Collaborator

DESCRIPTION OF CHANGES:

The use of ush/set_namelist.py is being replaced by the UW Tool set_config.py. The set_namelist.py has not been removed as it may still be of use as a command line tool when manually creating namelists from the parm/FV3.input.yml file.

All the python files in the ush directory (top level) have technically been made to pass the linter to facilitate easier testing commands. The files that were modified in the introduction of the set_config tool have been thoroughly linted for real. All others have been skipped with hopes that we can get to those later. Nothing changes about the approach to linting, but the burden of keeping up with which files conform or not is now on the file itself, not on the pylint caller.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

The hash to workflow-tools will need to be updated once PR 253 in that repo is merged.

DOCUMENTATION:

I'm not aware of changes that need to be made to docs. Guidance here would be helpful if I've missed something.

ISSUE:

Fixes Issue #829.

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

CONTRIBUTORS (optional):

@WeirAE @elcarpenter @j-derrico @fgabelmannjr @venitahagerty

@christinaholtNOAA
Copy link
Collaborator Author

christinaholtNOAA commented Jun 14, 2023

A quick note...the linter and the unittests are going to continue to fail until the update to workflow-tools is merged. Both pass locally in my space.

Actually...let me temporarily point to my branch. (EDIT: That seems to have done it.)

@MichaelLueken MichaelLueken linked an issue Jun 14, 2023 that may be closed by this pull request
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christinaholtNOAA Overall, these changes look good to me! I noted two minor spelling/grammatical issues, but that was all.

The fundamental and coverage tests were run on Hera Intel and Jet and all successfully passed (please note that this includes the current DT_ATMOS setting of 30 seconds for the RRFS_AK_3km test as well).

ush/set_ozone_param.py Outdated Show resolved Hide resolved
ush/update_input_nml.py Outdated Show resolved Hide resolved
christinaholtNOAA and others added 2 commits June 21, 2023 10:15
Co-authored-by: Michael Lueken <63728921+MichaelLueken@users.noreply.github.com>
Co-authored-by: Michael Lueken <63728921+MichaelLueken@users.noreply.github.com>
@christinaholtNOAA
Copy link
Collaborator Author

@MichaelLueken Thank you for your review. I think we are going to hold off for a sprint or two on this integration. We're taking a moment to apply lessons learned from this work, and refactor workflow-tools just a bit for a better end-user experience.

@christinaholtNOAA christinaholtNOAA deleted the replace_set_namelist branch December 8, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface Climo files not added to namelist correctly
2 participants