-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Integrate Unified Workflow tool set_config #830
[develop] Integrate Unified Workflow tool set_config #830
Conversation
A handful of other small changes associated with getting the tests to pass.
A quick note...the linter and the unittests are going to continue to fail until the update to workflow-tools is merged. Both pass locally in my space. Actually...let me temporarily point to my branch. (EDIT: That seems to have done it.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christinaholtNOAA Overall, these changes look good to me! I noted two minor spelling/grammatical issues, but that was all.
The fundamental and coverage tests were run on Hera Intel and Jet and all successfully passed (please note that this includes the current DT_ATMOS setting of 30 seconds for the RRFS_AK_3km test as well).
Co-authored-by: Michael Lueken <63728921+MichaelLueken@users.noreply.github.com>
Co-authored-by: Michael Lueken <63728921+MichaelLueken@users.noreply.github.com>
@MichaelLueken Thank you for your review. I think we are going to hold off for a sprint or two on this integration. We're taking a moment to apply lessons learned from this work, and refactor workflow-tools just a bit for a better end-user experience. |
DESCRIPTION OF CHANGES:
The use of
ush/set_namelist.py
is being replaced by the UW Toolset_config.py
. Theset_namelist.py
has not been removed as it may still be of use as a command line tool when manually creating namelists from theparm/FV3.input.yml
file.All the python files in the ush directory (top level) have technically been made to pass the linter to facilitate easier testing commands. The files that were modified in the introduction of the set_config tool have been thoroughly linted for real. All others have been skipped with hopes that we can get to those later. Nothing changes about the approach to linting, but the burden of keeping up with which files conform or not is now on the file itself, not on the pylint caller.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
The hash to workflow-tools will need to be updated once PR 253 in that repo is merged.
DOCUMENTATION:
I'm not aware of changes that need to be made to docs. Guidance here would be helpful if I've missed something.
ISSUE:
Fixes Issue #829.
CHECKLIST
CONTRIBUTORS (optional):
@WeirAE @elcarpenter @j-derrico @fgabelmannjr @venitahagerty