Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface Climo files not added to namelist correctly #829

Open
christinaholtNOAA opened this issue Jun 13, 2023 · 0 comments
Open

Surface Climo files not added to namelist correctly #829

christinaholtNOAA opened this issue Jun 13, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@christinaholtNOAA
Copy link
Collaborator

Your bug may already be reported!
Please search on the Issue tracker before creating a new issue.
If an issue already exists, please use that issue to add any additional information.

Expected behavior

The files in the FV3_NML_VARNAME_TO_SFC_CLIMO_FIELD_MAPPING section of parm/fixed_files_mapping.yaml should show up in the namsfc section of input namelist in the experiment directory.

Current behavior

When set_fv3nml_sfc_climo_filenames.py is run to update the namelist with the appropriate files names, it mistakenly adds a section to the namelist labeled "namsfc_dict" and leaves the values in the namsfc section empty. Those then default to the low resolution global gridded data set by the model.

Machines affected

All.

Steps To Reproduce

  1. Generate workflow for any of the fundamenal tests (any tests really).
  2. Open up the input.nml in the experiment directory.
  3. Check the namsfc and unused namsfc_dict sections to confirm the behavior described above.

Detailed Description of Fix (optional)

I caught the error when incorporating the Unified Workflow tools into SRW. I will include the fix as a part of the UW addition.

@christinaholtNOAA christinaholtNOAA added the bug Something isn't working label Jun 13, 2023
@christinaholtNOAA christinaholtNOAA self-assigned this Jun 13, 2023
christinaholtNOAA added a commit to christinaholtNOAA/ufs-srweather-app that referenced this issue Jun 13, 2023
@MichaelLueken MichaelLueken linked a pull request Jun 14, 2023 that will close this issue
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant