forked from ueckoken/plarail2021-soft
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto_operation にprotobuf の型ファイルを導入 #263
Merged
Merged
+921
−224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en/plarail2022 into auto-operation-type-check
ちょうど型定義がほしいと思っていたため、助かります……! auto_operation 本体の型付けは、今後やっていきます |
n4o847
approved these changes
Nov 15, 2022
@n4o847 https://github.com/ueckoken/plarail2022/actions/runs/3467966675/jobs/5793328370#step:5:13 |
@n4o847 CIでフォーマッタも導入しました |
型とフォーマットの整備ありがとうございます…… 🙏 CI 環境など、今後プラレーラーズの方の開発でも参考にさせていただきます @thgcMtdh も今ブランチ立ててコード書いてると思うので、確認しておくといいと思います |
n4o847
approved these changes
Nov 15, 2022
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyiファイルを生成させ、mypyで検査するつもりです
mypyでのチェックを合格させるには型アノテーションをつけてまわる仕事をしないといけないので取りあえずCIによるチェックは後回しにします
ついでにCIでフォーマッタも導入しました