Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto_operation に型アノテーションを付けて周る #276

Closed
Azuki-bar opened this issue Nov 15, 2022 · 0 comments
Closed

auto_operation に型アノテーションを付けて周る #276

Azuki-bar opened this issue Nov 15, 2022 · 0 comments
Assignees
@Azuki-bar
Labels
enhancement New feature or request

Comments

@Azuki-bar
Copy link
Member

内容

#263 でprotobufは型を生成しmypyも導入したがCIではチェックしていない。型アノテーションが付いていないためにエラーを吐いて止まるためである。

ので付けていく。

Pros 良くなる点

エディタの補完が効きやすくなる
CIで静的解析と型チェックができる

Cons 悪くなる点

めんどい

実現方法

その他
@Azuki-bar Azuki-bar added the enhancement New feature or request label Nov 15, 2022
@Azuki-bar Azuki-bar self-assigned this Nov 15, 2022
@Azuki-bar Azuki-bar mentioned this issue Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Azuki-bar Azuki-bar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

型アノテーションを付けた ueckoken/plarail2022
1 participant
@Azuki-bar