Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-3): provide app global #5354

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

Rirax
Copy link
Contributor

@Rirax Rirax commented Jul 16, 2024

Changes Overview

In refacto's work to improve rendering performance of vue-3 components we attached appContext to EditorContent but forgot to bind it to the rendered vNode.
#5206

Implementation Approach

We bind appContext on the rendered vNode

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

#5323

Copy link

changeset-bot bot commented Jul 16, 2024

⚠️ No Changeset found

Latest commit: 77246a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 77246a2
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/6696427b6fd28a000855f84d
😎 Deploy Preview https://deploy-preview-5354--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nperez0111 nperez0111 merged commit 8565862 into ueberdosis:vue-perf Jul 19, 2024
4 checks passed
@nperez0111 nperez0111 mentioned this pull request Jul 22, 2024
5 tasks
nperez0111 pushed a commit that referenced this pull request Jul 22, 2024
Co-authored-by: relchapt <reynald.lechapt@getmayday.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants