-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (vue-3) component rendering #5206
fix: (vue-3) component rendering #5206
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c8e5f9c
to
7ca826b
Compare
2085f38
to
2789e08
Compare
2789e08
to
edf61b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very excited to see this thank you @Rirax
I'm not super confident in vue to know where the edge cases might be for something like this. Would it be alright to just put into a beta & see if we get any feedback on it from other users?
I think that this approach could potentially help with our react integration as well. I'll need to think on how to actually do that |
This reverts commit 95a1d4b.
Whoops meant to release on develop not main. |
It looks like this has broken a few things in our app. I believe this is because https://tiptap.dev/docs/editor/extensions/nodes/mention To reproduce, simply type onKeyDown(props) {
if (props.event.key === 'Escape') {
popup[0].hide()
return true
}
return component.ref?.onKeyDown(props)
}, UPDATE |
Hello @james-astalty Perhaps a hotfix is useful to maintain compatibility with |
This would be great to have! |
This reverts commit 31f3746.
Hi @nperez0111 |
This reverts commit ff04353.
This reverts commit ff04353.
@Rirax, I found an issue with this PR here: #5373 (comment) Thanks for your support |
Changes Overview
This PR is a step forward in fixing performance issue with large documents migrating from vue 2 to vue 3.
#5031
Implementation Approach
Our approach is to eliminate the use of
Teleport
to locate elements in the DOM and the need to render the app each time for each new node.In the proposed changes we return to an implementation close to that of the vue-2 package.
Vue.extends
no longer exists in vue-3, so we've added arenderComponent
method toVueRenderer.ts
, which reproduces its behaviourTesting Done
Create a document requiring the rendering of more than 2000 vue components
Verification Steps
Additional Notes
Checklist
feat: Implement new feature
orchore(deps): Update dependencies
)Related Issues
#5031