Retain existing config when calling configure on Marks and Extensions (attempt 2) #3998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at addressing #3813. My first attempt, #3822, had to be reverted because of issues described in this comment. That comment described a defaultOptions warning that I was able to reproduce in my original approach, and I confirmed it's no longer present in this approach. cc @bdbch
Currently, when you call
.configure()
on aMark
orExtension
, theMark
orExtension
that's returned doesn't retain the config from the original.This is a problem for StarterKit. When
Code
is added to an editor added as a standalone extension, an inline code block isexitable
. When added as part of StarterKit, an inline code block is notexitable
because StarterKit callsCode.configure()
, blowing away the default config.This PR ensures that when you call
.configure()
on aMark
orExtension
, theMark
orExtension
that's returned retains the config from the original.closes #3813