Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code not exitable in StarterKit #3813

Closed
1 of 2 tasks
nholden opened this issue Mar 3, 2023 · 0 comments · Fixed by #3822
Closed
1 of 2 tasks

Code not exitable in StarterKit #3813

nholden opened this issue Mar 3, 2023 · 0 comments · Fixed by #3822
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@nholden
Copy link
Contributor

nholden commented Mar 3, 2023

What’s the bug you are facing?

#2925 allowed users to exit inline code blocks with the right arrow key. This behavior works when Code is included as a standalone extension, but it does not work when Code is included as part of StarterKit.

Which browser was this experienced in? Are any special extensions installed?

Chrome Version 110.0.5481.177, no special extensions

How can we reproduce the bug on our side?

Confirm that Code is not exitable as part of StarterKit:

  1. Go to the default code editor in the docs.
  2. At the bottom of the editor, type an inline code block in the editor by placing text between backticks.
  3. Click inside of the inline code block.
  4. Press the right arrow key many times, you won't be able to exit the inline code block.

Confirm that Code is exitable as a standalone extension:

  1. Go to the usage section of the Code docs.
  2. Click into the "This is code." inline code block in the editor.
  3. Press the right arrow key until you have exited the inline code block.

What did you expect to happen?

I expected Code to have the same exitable behavior as part of the StarterKit as it does as a standalone extension.

Anything to add? (optional)

My suspicion is that something within the extend method, which is called in StarterKit via configure, is breaking this behavior. These CodeSandboxes seem to confirm it:

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
1 participant