Feat/cleanup old GWAS UI app code

[pieterlukasse]

Jira Ticket: VADC-399

Improvements

• cleanup of OLD GWAS UI app code, keeping only V2 of the app and the Results viewer app

Deployment changes

• this will require some changes in other deployment related config files. See:
  • Feat: remove temporary GWAS++ entry gitops-qa#2362
  • Feat: remove temporary GWAS++ entry cdis-manifest#5713

[jarvisraymond-uchicago]

Great work Pieter! I pulled the changes locally and confirmed only one GWAS app remains without causing any obvious errors.

Before merging consider

• Do we want to rename the folder for the application from GWASV2 to GWAS now that there's only one GWAS left?
• For tickets like this: https://ctds-planx.atlassian.net/browse/VADC-323 should the developer reference this PR to find all the removed storybooks?
• Are there follow up tickets to implement the needed changes in other deployment related config files?

[jarvisraymond-uchicago]

Comment, no changes needed:

This was probably a bad approach to begin with. Better would have been to ignore the line or the entire file rather than adding a new global rule for one file.

[pieterlukasse]

Do we want to rename the folder for the application from GWASV2 to GWAS now that there's only one GWAS left?

Good point, although it is probably best to think of a more unique name, maybe GWASApp. Also, with "GWASV2" string having 162 hits in 37 files, this might be a bit large of a change to include here on top of all the other changes. I would prefer to do this in a separate action. There are some more cleanup actions that need to take place, e.g. the src/Analysis/GWASResults/GWASUIApp.css is probably way too large (a copy of the legacy versions) and is also referenced in a number of places where it really should not be.

Are there follow up tickets to implement the needed changes in other deployment related config files?

I've update the description with links to the other related PRs