Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: remove temporary GWAS++ entry #5713

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Conversation

pieterlukasse
Copy link
Contributor

..given uc-cdis/data-portal#1231

Link to Jira ticket if there is one: See PR above

Environments

  • VA test server

Description of changes

  • Removing temporary GWAS++ placeholder and preferring to keep GWASUIApp as the name to use.

@pieterlukasse pieterlukasse requested review from nmetokishlubsky and a team as code owners February 9, 2023 16:44
m0nhawk
m0nhawk previously approved these changes Feb 9, 2023
@m0nhawk m0nhawk marked this pull request as draft February 9, 2023 16:48
@m0nhawk
Copy link
Contributor

m0nhawk commented Feb 9, 2023

Looks good, waiting for merge of uc-cdis/data-portal#1231 👍

@pieterlukasse pieterlukasse marked this pull request as ready for review February 10, 2023 19:52
Copy link
Contributor

@m0nhawk m0nhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@m0nhawk m0nhawk merged commit a602ede into master Feb 10, 2023
@m0nhawk m0nhawk deleted the feat/update_gwasui_config branch February 10, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants