feat: add commit hash to comments #675

PhantomCracker · 2023-06-08T09:44:53Z

Resolves #663

0x4007 · 2023-06-08T10:27:24Z

Can you open a pull request on your fork and link it here to prove that it works? Otherwise can you post any other proof that it works?

PhantomCracker · 2023-06-16T10:25:04Z

Can you open a pull request on your fork and link it here to prove that it works? Otherwise can you post any other proof that it works?

Please check this PR: PhantomCracker#7

0x4007 · 2023-06-18T13:22:21Z

I don't see the commit hashes there. What are you showing with your linked pull request? I'm not asking to see the code. I'm asking to see proof that it works according to the spec.

ubiquibot · 2023-06-18T13:47:11Z

PhantomCracker · 2023-06-18T15:03:15Z

@pavlovcik recheck the PR please; here is also the proof of testing:

0x4007 · 2023-06-18T16:24:08Z

I don't see any comments posted by the bot with the commit hashes on your fork.

PhantomCracker · 2023-07-03T14:48:04Z

Please check the following GH action results: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5445801433/jobs/9905580034
Here is also a screenshot:

rndquu · 2023-07-04T08:28:49Z

@PhantomCracker pls check this PR rndquu#20

It prints [Deployment: Tue Jul 04 2023 08:22:14 (UTC) | Commit: 2c143d6c0018b081b8b8c865e6d9ff0647763c4a](https://a630927c.ubiquity-dollar-1cd.pages.dev/) but the latest commit hash is a82e8ca6894d37b50a3a336352362afb49e15101. So they are expected to match.

PhantomCracker · 2023-07-04T08:33:44Z

@PhantomCracker pls check this PR rndquu#20

It prints [Deployment: Tue Jul 04 2023 08:22:14 (UTC) | Commit: 2c143d6c0018b081b8b8c865e6d9ff0647763c4a](https://a630927c.ubiquity-dollar-1cd.pages.dev/) but the latest commit hash is a82e8ca6894d37b50a3a336352362afb49e15101. So they are expected to match.

Thank you for feedback, work in progress!

PhantomCracker · 2023-07-04T11:29:01Z

Hm... @rndquu i come back with different tests:
PhantomCracker@dcd6a09#comments
and PhantomCracker@6d39638#comments

I have also tried to create a new PR to test this: PhantomCracker#8
As you can see, the SHA is: a3b4d07 which is the same as in this action: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5453519281/jobs/9922468500
But the last commit have the following SHA: 975a329 which corresponds to this action: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5453525015/jobs/9922481199
The difference between these two is that on the first action, we display the SHA for the PR, while on the second we display the SHA for the commit PhantomCracker@975a329#comments

Is this the expected functionality?

rndquu · 2023-07-04T13:30:07Z

Hm... @rndquu i come back with different tests: PhantomCracker@dcd6a09#comments and PhantomCracker@6d39638#comments

I have also tried to create a new PR to test this: PhantomCracker#8 As you can see, the SHA is: a3b4d07 which is the same as in this action: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5453519281/jobs/9922468500 But the last commit have the following SHA: 975a329 which corresponds to this action: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5453525015/jobs/9922481199 The difference between these two is that on the first action, we display the SHA for the PR, while on the second we display the SHA for the commit PhantomCracker@975a329#comments

Is this the expected functionality?

pls merge the latest development branch and try again, commit hashes should be the same now

PhantomCracker · 2023-07-04T14:28:48Z

Indeed it works! 👍 🥳
Proof of testing: PhantomCracker#9

0x4007 · 2023-07-05T14:49:14Z

utils/print-deployments-logs.js

@@ -13,7 +13,7 @@ module.exports = async ({ github, context, fs }) => {
  const botCommentsArray = [];

  if (uniqueDeployUrl) {
-    defaultBody = `[Deployment: ${new Date()}](${uniqueDeployUrl})`;
+    defaultBody = `[Deployment: ${new Date()} | Commit: ${commitSha}](${uniqueDeployUrl})`;


Suggested change

defaultBody = `[Deployment: ${new Date()} | Commit: ${commitSha}](${uniqueDeployUrl})`;

defaultBody = `- [${commitSha}](${uniqueDeployUrl})`;

Can you also calculate the seven letter commit SHA like how GitHub displays it? I'm unsure if they slice the end or if they calculate it differently but it should match what shows in the UI (which if I recall is seven characters- sorry I'm on my phone GitHub client now it's not easy for me to check)

Sure, I will update it

0x4007 · 2023-07-06T20:52:29Z

I hope you verified that the way you're deriving the seven character SHA matches what GitHub displays or ill have to revert this.

PhantomCracker · 2023-07-07T01:38:25Z

I hope you verified that the way you're deriving the seven character SHA matches what GitHub displays or ill have to revert this.

For "dcd6a09fd116d210b173ca8569b94c8a1ab40a83" we will display dcd6a09.
Please let me know if something is wrong and I will fix it 😄

feat: add commit hash to comments

c1675ef

PhantomCracker requested a review from zgorizzo69 as a code owner June 8, 2023 09:44

fix: just show logs via git command

2130895

PhantomCracker added 2 commits June 18, 2023 17:22

fix: test

8e83a69

fix: remove logs

739b663

PhantomCracker added 19 commits June 19, 2023 12:00

fix: test bot comments

114bb9a

fix: test deploy

672880a

fix: remove token

f57e1ce

fix: tests

6f83317

fix: additional tests

c9538dc

fix: additional tests

41c3301

fix: remove condition

e576445

fix: prepare artifact

e23791a

fix: tes

5cdf554

fix: do additional checks

61cfbec

fix: install

baa3cc2

fix: t

d44334d

fix: update logs

d4efd9a

fix: update also the action

39d8a62

fix issue

4e1bcbc

fix: t

00c1fed

fix: p

36ca16e

fix: add fs

bc11c96

fix: revert changes

16e8b9d

PhantomCracker added 4 commits July 3, 2023 14:18

fix: need to obtain gh token

5873bac

Update print_deployments_logs.js

88c3790

Update print_deployments_logs.js

eb264e9

Update print_deployments_logs.js

f8aa01c

PhantomCracker marked this pull request as ready for review July 3, 2023 14:48

PhantomCracker added 5 commits July 3, 2023 18:21

Merge remote-tracking branch 'upstream/development' into 663

361ffd5

merge dev in 663

b3272e0

Delete workspace.xml

860eb30

fix merge

625768a

Merge branch '663' of github.com:PhantomCracker/ubiquity-dollar into 663

e4bc670

rndquu marked this pull request as draft July 4, 2023 08:28

PhantomCracker added 2 commits July 4, 2023 11:36

Update print-deployments-logs.js

ee492d4

Update build-and-test.yml

c96f12f

PhantomCracker marked this pull request as ready for review July 4, 2023 14:28

PhantomCracker added 2 commits July 4, 2023 17:31

Merge remote-tracking branch 'upstream/development' into 663

e8240e8

fix: remove logs

33d161f

rndquu approved these changes Jul 4, 2023

View reviewed changes

rndquu requested a review from 0x4007 July 4, 2023 15:14

0x4007 requested changes Jul 5, 2023

View reviewed changes

fix: use only 7 chars sha for commit

46cf34c

PhantomCracker requested a review from 0x4007 July 6, 2023 08:40

0x4007 merged commit f6e2d67 into ubiquity:development Jul 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add commit hash to comments #675

feat: add commit hash to comments #675

PhantomCracker commented Jun 8, 2023

0x4007 commented Jun 8, 2023

PhantomCracker commented Jun 16, 2023

0x4007 commented Jun 18, 2023

ubiquibot bot commented Jun 18, 2023 •

edited

Loading

PhantomCracker commented Jun 18, 2023

0x4007 commented Jun 18, 2023

PhantomCracker commented Jul 3, 2023

rndquu commented Jul 4, 2023

PhantomCracker commented Jul 4, 2023

PhantomCracker commented Jul 4, 2023

rndquu commented Jul 4, 2023

PhantomCracker commented Jul 4, 2023

0x4007 Jul 5, 2023

PhantomCracker Jul 6, 2023

0x4007 commented Jul 6, 2023

PhantomCracker commented Jul 7, 2023 •

edited

Loading

	defaultBody = `[Deployment: ${new Date()} \| Commit: ${commitSha}](${uniqueDeployUrl})`;
	defaultBody = `- [${commitSha}](${uniqueDeployUrl})`;

feat: add commit hash to comments #675

feat: add commit hash to comments #675

Conversation

PhantomCracker commented Jun 8, 2023

0x4007 commented Jun 8, 2023

PhantomCracker commented Jun 16, 2023

0x4007 commented Jun 18, 2023

ubiquibot bot commented Jun 18, 2023 • edited Loading

PhantomCracker commented Jun 18, 2023

0x4007 commented Jun 18, 2023

PhantomCracker commented Jul 3, 2023

rndquu commented Jul 4, 2023

PhantomCracker commented Jul 4, 2023

PhantomCracker commented Jul 4, 2023

rndquu commented Jul 4, 2023

PhantomCracker commented Jul 4, 2023

0x4007 Jul 5, 2023

Choose a reason for hiding this comment

PhantomCracker Jul 6, 2023

Choose a reason for hiding this comment

0x4007 commented Jul 6, 2023

PhantomCracker commented Jul 7, 2023 • edited Loading

ubiquibot bot commented Jun 18, 2023 •

edited

Loading

PhantomCracker commented Jul 7, 2023 •

edited

Loading