Fix compiler warnings

[rndquu]

Right now we have some compiler warnings

What should be done:

1. Fix compiler warnings
2. Make sure build and test workflow fails on any new warning introduced

[rndquu]

@pavlovcik could you set a priority?

[molecula451]

/start

[ubiquibot]

Skipping /start since the issue is closed

[ubiquibot]

[ CLAIM 200 WXDAI ]

0x4D0704f4...D826dCFc4

[rndquu]

@pavlovcik

there is a 2x multiplier for the current repo

this issue worth 300 USD generated a permit worth 600 WXDAI (which is expected because of the 2x multiplier)

the current issue is worth 200 USD so the permit was expected to be 400 WXDAI instead of 200 WXDAI

am I right?

[0x4007]

I'm pretty sure the generated permit is current because it was only seven minutes ago

[rndquu]

I'm pretty sure the generated permit is current because it was only seven minutes ago

I don't get you mean by "current". This permit should be 400 WXDAI because of the 2x multiplier, right?

[molecula451]

Thank you guys you fixing it @pavlovcik ?

[molecula451]

upss @pavlovcik i think @rndquu is clearer than waters 😁

[molecula451]

re-issue 🙏🏻@pavlovcik

[0x4007]

This pricing is accurate for this issue.

The problem is only in the following scenario:

1. Base-rate is 1000
2. Bounty is created (price label set to 100 USD)
3. Admin updates base-rate to 2000
4. Price labels are not automatically updated yet (we have a feature in the works to handle this, but it's not on production as far as I'm aware)
5. Bounty hunter completes the bounty and the payment permit is 200 USD even though the price label is still left at 100 USD.

---

This current issue was created after the base-rate was updated, so the price label is including the boosted base-rate and is accurate.

[rndquu]

This pricing is accurate for this issue.

The problem is only in the following scenario:

1. Base-rate is 1000
2. Bounty is created (price label set to 100 USD)
3. Admin updates base-rate to 2000
4. Price labels are not automatically updated yet (we have a feature in the works to handle this, but it's not on production as far as I'm aware)
5. Bounty hunter completes the bounty and the payment permit is 200 USD even though the price label is still left at 100 USD.

This current issue was created after the base-rate was updated, so the price label is including the boosted base-rate and is accurate.

Yes, you're right. Normally we have 100 USD for <1 day time labels but this issue is already set to 200 USD because of the multiplier.

@molecula451 pls notice that the pricing is accurate