Make NftReward contract upgradeable #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I run forge build, builded correctly, let me know if is needed something else. |
Paste the entire link to the issue you are trying to link to instead of #1043 |
Like that? |
rndquu
requested changes
Feb 7, 2024
rndquu
reviewed
Feb 8, 2024
rndquu
requested changes
Feb 8, 2024
|
I just remove the override methods, seems unnecessary now. |
rndquu
requested changes
Feb 9, 2024
|
Now the remapping seems correctly :) |
rndquu
approved these changes
Feb 9, 2024
gitcoindev
approved these changes
Feb 14, 2024
|
Looks like you guys forgot to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1043 issue.