Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NftReward contract upgradeable #1

Closed
rndquu opened this issue Dec 6, 2023 · 16 comments · Fixed by #6
Closed

Make NftReward contract upgradeable #1

rndquu opened this issue Dec 6, 2023 · 16 comments · Fixed by #6

Comments

@rndquu
Copy link
Member

rndquu commented Dec 6, 2023

There is the NftReward contract responsible for minting NFTs using a minter's signature. We should make the contract to be upgradeable.

What should be done:

  1. Make NftReward contract upgradeable (using openzeppelin's UUPS contracts)
  2. Update the deployment script
@rndquu rndquu added help wanted Extra attention is needed Time: <1 Day Priority: 1 (Normal) and removed help wanted Extra attention is needed labels Dec 29, 2023
Copy link

ubiquibot bot commented Dec 29, 2023

! action has an uncaught error

Copy link

ubiquibot bot commented Dec 29, 2023

! action has an uncaught error

@gpylypchuk
Copy link
Contributor

/start

@rndquu
Copy link
Member Author

rndquu commented Feb 5, 2024

/start

You're free to start, not sure why the bot is not responding

@0x4007
Copy link
Member

0x4007 commented Feb 6, 2024

I think it assigns now only on pull request opened. I don't think this was intentional but I'm also okay with this behavior.

@0x4007
Copy link
Member

0x4007 commented Feb 7, 2024

/query @gpylypchuk

Copy link

ubiquibot bot commented Feb 7, 2024

! action has an uncaught error

@0x4007
Copy link
Member

0x4007 commented Feb 7, 2024

@gpylypchuk can you set your wallet address so that the bot can assign you, and you can receive rewards?

@gpylypchuk
Copy link
Contributor

/wallet 0x1dddd6dd3e59fbc5c576536c0d5f7adb69c0ad45

Copy link

ubiquibot bot commented Feb 7, 2024

+ Successfully registered wallet address

@gpylypchuk
Copy link
Contributor

/start

Copy link

ubiquibot bot commented Feb 7, 2024

Warning! This task was created over 62 days ago. Please confirm that this issue specification is accurate before starting.
DeadlineThu, Feb 8, 5:36 AM UTC
Registered Wallet 0x1dddd6dd3e59fbc5c576536c0d5f7adb69c0ad45
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@gpylypchuk
Copy link
Contributor

/wallet 0x3ac293A770B62F7fECCe918dCC361a594b7f68eA

Copy link

ubiquibot bot commented Feb 8, 2024

+ Successfully registered wallet address

@0x4007 0x4007 closed this as completed in #6 Feb 15, 2024
Copy link

ubiquibot bot commented Feb 15, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Feb 15, 2024

[ 6.8 WXDAI ]

@pavlovcik
Contributions Overview
ViewContributionCountReward
IssueComment24.4
ReviewComment22.4
Conversation Incentives
CommentFormattingRelevanceReward
I think it assigns now only on pull request opened. I don't thin...
2.50.282.5
@gpylypchuk can you set your wallet address so that the bot can ...
1.90.081.9
> Resolves #1043

Paste the entire link to the issue you are try...

1.60.091.6
Looks like you guys forgot to merge this. ...
0.80.010.8

[ 203 WXDAI ]

@gpylypchuk
Contributions Overview
ViewContributionCountReward
IssueTask1.00200
ReviewComment43
Conversation Incentives
CommentFormattingRelevanceReward
I run forge build, builded correctly, let me know if is needed s...
1.40.551.4
> > Resolves #1043 > > Paste the entire link to the issue you...
0.20.190.2
I just remove the override methods, seems unnecessary now....
0.90.190.9
Now the remapping seems correctly :)...
0.50.090.5

[ 16.4 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
IssueSpecification113.8
IssueComment12.6
Conversation Incentives
CommentFormattingRelevanceReward
There is the [NftReward](https://github.com/ubiquity/nft-rewards...
13.8
a:
  count: 4
  score: "4"
  words: 6
li:
  count: 2
  score: "2"
  words: 55
113.8
> /start

You're free to start, not sure why the bot is not re...

2.60.222.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants