Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test against Error Prone 2.15.0 #665

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Build and test against Error Prone 2.15.0 #665

merged 2 commits into from
Sep 30, 2022

Conversation

msridhar
Copy link
Collaborator

EP 2.15.0 has a check enabled by default that we want to disable (see google/error-prone#3366). We cannot just disable this check with the existing config, since it does not exist in version 2.10.0, the latest version that works with JDK 8. Rather than adding conditional config around this one check, this PR disables compiling our code with Error Prone checks on JDK 8. We still check all our code with Error Prone on JDK 11+, and we are still running our own tests on JDK 8 (for now; see #634).

Beyond the config changes, no code changes were required.

@coveralls
Copy link

coveralls commented Sep 29, 2022

Pull Request Test Coverage Report for Build #966

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 92.552%

Files with Coverage Reduction New Missed Lines %
../nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPath.java 2 95.77%
Totals Coverage Status
Change from base Build #964: -0.04%
Covered Lines: 4933
Relevant Lines: 5330

💛 - Coveralls

Copy link
Contributor

@ketkarameya ketkarameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@msridhar msridhar enabled auto-merge (squash) September 30, 2022 18:53
@msridhar msridhar merged commit 92d94a7 into master Sep 30, 2022
@msridhar msridhar deleted the ep-2.15 branch September 30, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants