Build and test against Error Prone 2.15.0 #665
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EP 2.15.0 has a check enabled by default that we want to disable (see google/error-prone#3366). We cannot just disable this check with the existing config, since it does not exist in version 2.10.0, the latest version that works with JDK 8. Rather than adding conditional config around this one check, this PR disables compiling our code with Error Prone checks on JDK 8. We still check all our code with Error Prone on JDK 11+, and we are still running our own tests on JDK 8 (for now; see #634).
Beyond the config changes, no code changes were required.