Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for running on JDK / Java 8 #634

Closed
msridhar opened this issue Aug 8, 2022 · 3 comments
Closed

Remove support for running on JDK / Java 8 #634

msridhar opened this issue Aug 8, 2022 · 3 comments
Labels
longterm

Comments

@msridhar
Copy link
Collaborator

msridhar commented Aug 8, 2022

Error Prone dropped support for Java 8 several months ago:

https://github.com/google/error-prone/releases/tag/v2.11.0

Dropping Java 8 support will allow us to clean up several ugly hacks in the NullAway code and build configuration. We'll aim to cut one final release supporting Java 8 before doing this.
@lazaroclapp lazaroclapp mentioned this issue Sep 9, 2022
Open
@msridhar msridhar mentioned this issue Sep 29, 2022
Merged
msridhar added a commit that referenced this issue Sep 30, 2022
@msridhar
Build and test against Error Prone 2.15.0 (#665)
92d94a7 
EP 2.15.0 has a check enabled by default that we want to disable (see google/error-prone#3366).  We cannot just disable this check with the existing config, since it does not exist in version 2.10.0, the latest version that works with JDK 8.  Rather than adding conditional config around this one check, this PR disables compiling our code with Error Prone checks on JDK 8.  We still check all our code with Error Prone on JDK 11+, and we are still running our own tests on JDK 8 (for now; see #634).

Beyond the config changes, no code changes were required.
@msridhar
Copy link
Collaborator Author

Upon further thought, I think we shouldn't be too aggressive in dropping Java 8 support. There are scenarios in which libraries that still want to target Java 8 would want to build on a JDK 8 JVM, and NullAway dropping that support would make things more inconvenient. I think we can survive with the hacks we have for now. Leaving this open as we want to do this eventually

@msridhar
Copy link
Collaborator Author

We're now at the end of 2023, and I think we should aim to drop support for running NullAway on JDK 8 in the near future. Specifically, I propose:

  1. In the next release, document that we plan for that release to be the last that supports running on JDK 8.
  2. Assuming we do not learn of any major issues, drop support in the following release, potentially doing a larger version number bump to indicate a significant change.

@lazaroclapp @yuxincs thoughts?

@msridhar msridhar mentioned this issue Dec 20, 2023
Open
@msridhar
Copy link
Collaborator Author

This was done a while back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
longterm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msridhar