Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated etl_profile.js to add an extra group_by parameter "show_all_dimension_values". #1588

Merged
merged 12 commits into from
Dec 17, 2021
Merged

Updated etl_profile.js to add an extra group_by parameter "show_all_dimension_values". #1588

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ad7dbe1
Added show_all_dimension_values flag to group_by.
hltaylor26 Dec 15, 2021
bf97b45
Removed whitespace and unnecessary default to false (already defaults…
hltaylor26 Dec 15, 2021
382b0ac
Merge branch 'xdmod10.0' of https://github.com/ubccr/xdmod into etl_p…
hltaylor26 Dec 15, 2021
23520e0
Made minor change to comment in code so CircleCI tests will run after…
hltaylor26 Dec 15, 2021
706eb65
Merge branch 'xdmod10.0' into etl_profile_changes
hltaylor26 Dec 16, 2021
252926a
Merge branch 'xdmod10.0' into etl_profile_changes
hltaylor26 Dec 16, 2021
c9f8c11
Merge branch 'xdmod10.0' into etl_profile_changes
hltaylor26 Dec 17, 2021
6c2c841
Added a minor change to a comment in the code to trigger CircleCI tes…
hltaylor26 Dec 17, 2021
5333eeb
Fixed issue with style tests.
hltaylor26 Dec 17, 2021
9e0715a
Merge branch 'xdmod10.0' into etl_profile_changes
hltaylor26 Dec 17, 2021
81b01df
Merge branch 'xdmod10.0' into etl_profile_changes
hltaylor26 Dec 17, 2021
709be43
Merge branch 'xdmod10.0' into etl_profile_changes
hltaylor26 Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions etl/js/lib/etl_profile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,8 @@ ETLProfile.prototype.getAggregationTables = function () {
dimension_table: agg.dimension_table,
category: agg.category,
def: agg.def || f.def,
dimension: agg.dimension || false
dimension: agg.dimension || false,
show_all_dimension_values: agg.show_all_dimension_values || false
};
newf.name = newf.name.replace(/\:field_name/g, field);
newf.sql = agg.sql || newf.name;
Expand Down Expand Up @@ -507,7 +508,7 @@ var xdmodIntegrator = function(realmName, realmConfigRoot) {

this.write = function() {

// Sort role configuration data and output
// Sort role configuration data and output.

roles.sort(self.groupbysorter("group_by"));

Expand Down Expand Up @@ -698,7 +699,8 @@ var generateGroupBy = function (itemAlias, column)
},
data_sort_order: null,
description_html: description,
name: label || itemAlias
name: label || itemAlias,
show_all_dimension_values: column.show_all_dimension_values
};
}

Expand Down Expand Up @@ -970,7 +972,7 @@ ETLProfile.prototype.regressionTests = function () {

this.datasets.forEach(function (dataset) {
try {
// Check that the getQuery and MarkAsDone functions can be called
// Check that the getQuery and MarkAsDone functions can be called.
if ( dataset.input.getQuery() == null ) {
throw "GetQuery returned null";
}
Expand Down