Updated etl_profile.js to add an extra group_by parameter "show_all_dimension_values". #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
jpwhite4
requested changes
Dec 15, 2021
etl/js/lib/etl_profile.js
Outdated
| @@ -698,7 +699,8 @@ var generateGroupBy = function (itemAlias, column) | |||
| }, | |||
| data_sort_order: null, | |||
| description_html: description, | |||
| name: label || itemAlias | |||
| name: label || itemAlias, | |||
| show_all_dimension_values: column.show_all_dimension_values || false | |||
There was a problem hiding this comment.
probably don't need the || false here since the column has this property (from line 373)
etl/js/lib/etl_profile.js
Outdated
| @@ -764,7 +766,7 @@ ETLProfile.prototype.integrateWithXDMoD = function () { | |||
| } | |||
| xdmodInteg.addGroupBy(itemName, tableColumns[tc].roles); | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Please remove this whitespace addition. It messes up the git blame
… to false in addAggregationField).
…rofile_changes
hltaylor26
force-pushed
the
etl_profile_changes
branch
from
0493192
to
382b0ac
Compare
jpwhite4
previously approved these changes
Dec 16, 2021
jpwhite4
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update adds the show_all_dimension_values flag to any group_bys generated by the etl.schema file in other realms. Defaults to false when created.
Motivation and Context
Allows for specific dimensions to return all values when need. For example, we want all CPU User buckets to show in the Efficiency Tab and setting this flag to true allows for the possibility for any user to access all possible buckets (not just buckets which contain their data).
Tests performed
Tested in docker.
Checklist: