-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated etl_profile.js to add an extra group_by parameter "show_all_dimension_values". #1588
Conversation
etl/js/lib/etl_profile.js
Outdated
@@ -698,7 +699,8 @@ var generateGroupBy = function (itemAlias, column) | |||
}, | |||
data_sort_order: null, | |||
description_html: description, | |||
name: label || itemAlias | |||
name: label || itemAlias, | |||
show_all_dimension_values: column.show_all_dimension_values || false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably don't need the || false
here since the column has this property (from line 373)
etl/js/lib/etl_profile.js
Outdated
@@ -764,7 +766,7 @@ ETLProfile.prototype.integrateWithXDMoD = function () { | |||
} | |||
xdmodInteg.addGroupBy(itemName, tableColumns[tc].roles); | |||
} | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this whitespace addition. It messes up the git blame
… to false in addAggregationField).
…rofile_changes
0493192
to
382b0ac
Compare
Description
This update adds the show_all_dimension_values flag to any group_bys generated by the etl.schema file in other realms. Defaults to false when created.
Motivation and Context
Allows for specific dimensions to return all values when need. For example, we want all CPU User buckets to show in the Efficiency Tab and setting this flag to true allows for the possibility for any user to access all possible buckets (not just buckets which contain their data).
Tests performed
Tested in docker.
Checklist: