Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the "Show in X tab" label in the Metric Explorer automatically based on whether the dashboard is enabled #1400

Merged
merged 6 commits into from
Dec 3, 2020
Merged

Set the "Show in X tab" label in the Metric Explorer automatically based on whether the dashboard is enabled #1400

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b292765
Automatically set the "Show in X tab" label
jpwhite4 Jul 24, 2020
c6e021f
const is allowed in all or supported browsers.
jpwhite4 Jul 24, 2020
446fbec
Merge branch 'xdmod9.0' into dashsum
ryanrath Aug 6, 2020
03146b8
Merge branch 'xdmod9.5' into dashsum
jpwhite4 Oct 28, 2020
7c05c26
Merge branch 'xdmod9.5' into dashsum
jpwhite4 Nov 20, 2020
55a332a
Merge branch 'xdmod9.5' into dashsum
jpwhite4 Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions html/gui/js/modules/metric_explorer/MetricExplorer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3336,16 +3336,19 @@ Ext.extend(XDMoD.Module.MetricExplorer, XDMoD.PortalModule, {

// ---------------------------------------------------------

var summaryTab = Ext.getCmp('tg_summary');
var summaryTabName = summaryTab ? summaryTab.title : 'Summary';

this.featuredCheckbox = new Ext.form.Checkbox({
id: 'me_featured',
fieldLabel: 'Featured',
name: 'featured',
boxLabel: 'Show in Summary tab',
boxLabel: 'Show in ' + summaryTabName + ' tab',
checked: this.featured,
listeners: {
scope: this,
'check': function(checkbox, check) {
XDMoD.TrackEvent('Metric Explorer', 'Toggled Show in Summary tab checkbox', Ext.encode({
XDMoD.TrackEvent('Metric Explorer', 'Toggled Show in ' + summaryTabName + ' tab checkbox', Ext.encode({
checked: check
}));

Expand Down