Set the "Show in X tab" label in the Metric Explorer automatically based on whether the dashboard is enabled #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ternary is in there so that the metric explorer does not break if you switch the sumary/dashboard tab off completely |
but it is too tricky to get eslint to allow that without turning on a load of es6 stuff (some of which is not allowed).
ryanrath
previously approved these changes
Aug 3, 2020
jpwhite4
changed the title
plessbd
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://app.asana.com/0/342819846538629/1145402702473881
This one has probably missed the 9.0.0 train, but I'm putting it up here anyway so it doesn't get forgotten about for 9.5