Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-scalajs, scalajs-compiler to 1.0.1 #888

Closed

Conversation

scala-steward
Copy link
Contributor

Updates

from 0.6.32 to 1.0.1.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-js" } ]

labels: library-update, semver-major

@larsrh
Copy link
Contributor

larsrh commented Mar 28, 2020

Blocked on machinist. Needs a similar PR as typelevel/cats#2925.

@cosmin33
Copy link

Why is that ? Machinist can't work on scalajs 1.0 ?
In the cats PS the problem with machinist was Dotty, not scalajs 1.0 as I understand...

@cosmin33
Copy link

cosmin33 commented Apr 20, 2020

I managed to update spire for scalajs 1.0.1. But machinist dependency being an archived project I had to modify and publish locally. This is the script to locally publish the current spire snapshot for scalajs 1.0.1:

git clone https://github.com/cosmin33/machinist.git
cd machinist
sbt publishLocal
cd ..
git clone https://github.com/cosmin33/spire.git
cd spire
sbt publishLocal
cd ..

I can make a PR but I don't know how to proceed with machinist. Any ideas ?
In the mean time the forked repos are there for future reference.

@erikerlandson
Copy link
Contributor

What is spire's roadmap for dealing with archival of machinist?

@erikerlandson
Copy link
Contributor

erikerlandson commented May 18, 2020

machinist effectively consists of a single file: Ops.scala - if the machinist project is dead, but spire depends on it then...

@denisrosset to unblock migration to scalaJS 1.x, I'd propose moving Ops.scala back into spire. It's only used in the macros project for Syntax.scala

@denisrosset
Copy link
Collaborator

@erikerlandson Totally agree. I'm doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants