Replace machinist macros by plain forwarders #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaJCB
previously approved these changes
Jun 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #2925 +/- ##
==========================================
- Coverage 94.24% 94.19% -0.06%
==========================================
Files 367 366 -1
Lines 7002 7026 +24
Branches 195 185 -10
==========================================
+ Hits 6599 6618 +19
- Misses 403 408 +5
Continue to review full report at Codecov.
|
smarter
force-pushed
the
remove-machinist
branch
from
697d910
to
7290b37
Compare
|
Forgot to actually remove it from the build. |
This was referenced Jun 30, 2019
smarter
force-pushed
the
remove-machinist
branch
from
7290b37
to
11d972b
Compare
Partial fix for typelevel#2553. After removing the machinist dependency, the build failed on simulacrum annotations because scala-reflect wasn't on the classpath anymore, so we add it as an explicit dependency. Co-authored-by: drdozer <turingatemyhamster@gmail.com>
smarter
force-pushed
the
remove-machinist
branch
from
11d972b
to
59cc818
Compare
kailuowang
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #2553.
Co-authored-by: drdozer turingatemyhamster@gmail.com