Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shrinking from gen-based Prop.forAll #440

Closed
wants to merge 8 commits into from
Closed

Remove shrinking from gen-based Prop.forAll #440

wants to merge 8 commits into from

Commits on Nov 23, 2018

  1. Remove shrinking from gen-based Prop.forAll 

    Shrinking is only safe when used with Arbitrary.
Generators can have a smaller range than the global shrinking,
which results in invalid shrunken values.

This fixes issues like typelevel#129.
    @charleso
    charleso committed Nov 23, 2018
    Configuration menu
    Copy the full SHA
    136f7df View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2018

  1. Restore bincompat & deprecate Gen.forAll w/ Shrink

    @dwijnand
    dwijnand committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    663c542 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from dwijnand/Gen.forAll-without-Shrink 

    Restore bincompat & deprecate Gen.forAll w/ Shrink
    @charleso
    charleso authored Nov 24, 2018
    Configuration menu
    Copy the full SHA
    08fbd2a View commit details
    Browse the repository at this point in the history

  3. Deprecate Gen-taking forAllNoShrink 

    Swap the impls, so the deprecated API calls the not deprecated API.
    @dwijnand
    dwijnand committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    c3ccd4f View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2 from dwijnand/Gen.forAll-without-Shrink 

    Deprecate Gen-taking forAllNoShrink
    @charleso
    charleso authored Nov 24, 2018
    Configuration menu
    Copy the full SHA
    7fbb1d2 View commit details
    Browse the repository at this point in the history

  5. Add version to forAll deprecated annotation

    @charleso
    charleso committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    06fc1b0 View commit details
    Browse the repository at this point in the history

  6. Rename implicit param to fix resolution due to name ambiguity

    @charleso
    charleso committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    be680b1 View commit details
    Browse the repository at this point in the history

  7. Switch to forAll instead of deprecated forAllNoShink

    @charleso
    charleso committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    86fdea6 View commit details
    Browse the repository at this point in the history