Deprecate Gen-taking forAllNoShrink

[dwijnand]

Swap the impls, so the deprecated API calls the not deprecated API.

[charleso]

I think I'd worry about the impact of this change a little more. Not because it's not a good thing to do (it is), but because if someone has deprecated warnings as errors turned on (like we do for our projects), this is going to require lots of refactoring.

Thoughts?

[dwijnand]

Thoughts?

My thoughts are that -Xfatal-warnings is a very blunt tool, which always has that effect. It's a sad state of affairs, and one we should fix, but I don't think it should halt changes like this, at least not always.

[dwijnand]

Oh! Reading scala/bug#8410 it looks like you can disable deprecation warnings with -deprecation:false? TIL. So that's the stopgap you can use while transitioning. It's still a little blunt (being all deprecation warnings), but it's something.

[charleso]

but I don't think it should halt changes like this, at least not always.

Fair enough. I love -Xfatal-warnings for the most part, but the lack of finer controls for ignoring deprecation warnings is sorely missing.

[dwijnand]

It might finally be coming: scala/scala-dev#333

[charleso]

It might finally be coming: scala/scala-dev#333

Awesome! Thanks for the link, that's good to know.