Pull - fix Translate bug. #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diesalbla
changed the title
diesalbla
force-pushed
the
translate_bug
branch
from
0127c48 to
787de45
Compare
Looking at the translate method, I noticed that, strangely enough, it was not using the `view` or continuation. This means that any stream after a Translate would be dropped. This was not detected because, in the StreamTranslateSuite, none of the unit/property tests was appending something after the translation. This would be embarrassing. Along the way, we also add a leak test that uses translate.
diesalbla
force-pushed
the
translate_bug
branch
from
787de45 to
e5385dd
Compare
|
Nice find! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the translate method, I noticed that, strangely enough, it was not using the
viewor continuation. This means that any stream after a Translate would be dropped. This was not detected because, in theStreamTranslateSuite, none of the unit/property tests was appending something after the translation. Along the way, we also add a leak test that uses translate, to cover that a little bit.