Ata 6069 connector leak upgrades #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leak Signed-off-by: Shailesh <shailesh.patil@iohk.io>
Signed-off-by: Shailesh <shailesh.patil@iohk.io>
mineme0110
requested review from
a team,
loverdos and
atala-dev
and removed request for
a team
Signed-off-by: Shailesh <shailesh.patil@iohk.io>
AlexITC
reviewed
Feb 1, 2022
| @@ -154,6 +157,7 @@ object Dependencies { | |||
| "com.thesamet.scalapb" %% "scalapb-runtime" % scalapb.compiler.Version.scalapbVersion % "protobuf", | |||
| "com.thesamet.scalapb" %% "scalapb-runtime-grpc" % scalapb.compiler.Version.scalapbVersion | |||
| ) | |||
| val overrideVersionSchemes = libraryDependencySchemes += "org.tpolecat" %% "doobie-core" % VersionScheme.Always | |||
There was a problem hiding this comment.
@AlexITC I tried explained in the PR description but maybe not provided full context
There 1.0.0-RC2 is incompatible because sbt Versioning is added
https://github.com/lloydmeta/enumeratum/releases/tag/enumeratum-doobiev1.5.17 is still on 0.13.4 Doobie
But in Doobie 1.0.0-RC2 they have an update on strict sbt versioning, so it doesn't work I get the error described in tthe PR , enumeratum-doobie needs to have a release to fix this. I saw its on snaphot not released
There was a problem hiding this comment.
I'd add a comment in this line to mention we are waiting for enumaratum to upgrade its doobie dependency.
Thanks for explaining.
AlexITC
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Connector leaks connection when the stream is empty.
typelevel/fs2#2614 This PR fixes the bug in fs2.
To fix the version conflict on library added libraryDependencySchemes
unless there is another way to resolve the below is the error which is coming due to doobie version update 1.0.0-RC2
java.lang.RuntimeException: found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error]
[error] * org.tpolecat:doobie-core_2.13:1.0.0-RC2 (early-semver) is selected over 0.13.4
[error] +- io.iohk:management-console_2.13:1.2-635c44f6 (depends on 1.0.0-RC2)
[error] +- io.iohk:common_2.13:1.2-635c44f6 (depends on 1.0.0-RC2)
[error] +- org.tpolecat:doobie-postgres_2.13:1.0.0-RC2 (depends on 1.0.0-RC2)
[error] +- org.tpolecat:doobie-hikari_2.13:1.0.0-RC2 (depends on 1.0.0-RC2)
[error] +- org.tpolecat:doobie-postgres-circe_2.13:1.0.0-RC2 (depends on 1.0.0-RC2)
[error] +- com.beachape:enumeratum-doobie_2.13:1.7.0 (depends on 0.13.4)
[error]
[error]
[error] this can be overridden using libraryDependencySchemes or evictionErrorLevel
Screenshots
Checklists
Pre-submit checklist:
Pre-merge checklist: