Backports for a cats-1.6.x patch #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evel#2810) * Add regression test for MonadErrorOps bug * Change MonadErrorOps#reject so it no longer re-runs the effect it is called on. Fixes typelevel#2809
Changed description to better fit their implentation
We are running into Spark `Task not serializable` issues when a closure that executes on a Spark executor node involves a `Map` that is created via running `foldMap` on a `List`. This commit makes the `WrappedMutableMap` hierarchy extend `Serializable` and chex that the cerealization works (this test failed before extending `Serializable`).
kailuowang
approved these changes
May 29, 2019
|
Thanks for the backport. I wish we didn't need to do this. It's unfortunate that we got held up by a dependency only needed for |
LukaJCB
approved these changes
May 29, 2019
|
Any thoughts on going all the way to a 1.7 vs this more modest approach? |
|
I think the more modest approach makes sense, I'd rather focus on getting 2.0 out the door, e.g. by pulling out |
|
Okay. I should be able to release this tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the features in v2.0.0-M1 and v2.0.0-M2 are suitable for backporting:
For v1.6.x:
Alternatively or additionally, we could do a 1.7.x, and get several more while we await 2.0.0:
foldFtoEitherT#2780object CommutativeApplicativeto getCommutativeMonoid#2747TraverseFilterinstance forSetto alleycats #2726toFreeTtoFree#2724adaptErrtoApplicativeErrorOps#2698deferfactory method toContT#2696