Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MonadErrorOps#reject so it no longer runs effects twice #2810

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Change MonadErrorOps#reject so it no longer runs effects twice #2810

merged 2 commits into from
Apr 25, 2019

Conversation

bplommer
Copy link
Contributor

Fixes #2809

@bplommer bplommer mentioned this pull request Apr 25, 2019
Closed
@LukaJCB
Copy link
Member

LukaJCB commented Apr 25, 2019

Thanks for bringing this to our attention, this indeed sounds like a bug. Technically this is a breaking change, but I think we should merge this as a bug fix 👍

kailuowang
kailuowang approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kailuowang kailuowang merged commit 0d6aafc into typelevel:master Apr 25, 2019
@kailuowang kailuowang added the bug label Apr 25, 2019
@kailuowang kailuowang modified the milestones: 2.0.0-M1, 2.0.0-RC1 Apr 25, 2019
@bplommer bplommer deleted the reject-bugfix-pr branch April 25, 2019 22:51
rossabaker pushed a commit to rossabaker/cats that referenced this pull request May 26, 2019
@rossabaker
Change MonadErrorOps#reject so it no longer runs effects twice (typel…
3c783f6 
…evel#2810)

* Add regression test for MonadErrorOps bug

* Change MonadErrorOps#reject so it no longer re-runs the effect it is called on. Fixes typelevel#2809
@rossabaker rossabaker mentioned this pull request May 26, 2019
Merged
rossabaker added a commit that referenced this pull request Jun 3, 2019
@rossabaker
Backports for a cats-1.6.x patch (#2861)
de0056b 
* Change MonadErrorOps#reject so it no longer runs effects twice (#2810)

* Add regression test for MonadErrorOps bug

* Change MonadErrorOps#reject so it no longer re-runs the effect it is called on. Fixes #2809

* Fix Order.max and Oder.min description comments (#2842)

Changed description to better fit their implentation

* Make WrappedMutableMapBase extend Serializable (#2784)

We are running into Spark `Task not serializable` issues when a closure
that executes on a Spark executor node involves a `Map` that is created
via running `foldMap` on a `List`. This commit makes the
`WrappedMutableMap` hierarchy extend `Serializable` and chex that the
cerealization works (this test failed before extending `Serializable`).

* Optimize productR in Apply (#2728)
@kailuowang kailuowang modified the milestones: 2.0.0-RC1, 2.0.0-M2 Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailuowang kailuowang kailuowang approved these changes

@LukaJCB LukaJCB LukaJCB approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0.0-M2
Development

Successfully merging this pull request may close these issues.

MonadErrorOps#reject runs non-rejected effects twice
3 participants
@bplommer @LukaJCB @kailuowang