Rename EitherT.liftT to EitherT.liftF #1947

aeons · 2017-10-03T15:33:29Z

To be consistent with OptionT.liftF.

Fixes #1945

kailuowang · 2017-10-03T15:43:07Z

I like the change. I wonder if we should help migration by providing a deprecated alias, or scalafix?

aeons · 2017-10-03T16:28:57Z

I think I have a scalafix rule implemented now, but how do I make it run against my locally build cats?

LukaJCB · 2017-10-03T16:34:14Z

You go into the scalafix folder and run the tests there :)

kailuowang · 2017-10-03T16:41:53Z

I loved the scalafix, but can we have the alias as well, it's very cheap.

To be consistent with OptionT.liftF.

codecov-io · 2017-10-03T19:31:14Z

Codecov Report

Merging #1947 into master will increase coverage by 0.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1947      +/-   ##
==========================================
+ Coverage   95.57%   95.72%   +0.14%     
==========================================
  Files         248      278      +30     
  Lines        4454     4860     +406     
  Branches      117      125       +8     
==========================================
+ Hits         4257     4652     +395     
- Misses        197      208      +11

Impacted Files	Coverage Δ
core/src/main/scala/cats/ApplicativeError.scala	`88.23% <ø> (ø)`	⬆️
core/src/main/scala/cats/data/EitherT.scala	`97.56% <100%> (-0.8%)`	⬇️
core/src/main/scala/cats/syntax/flatMap.scala	`75% <0%> (-25%)`	⬇️
kernel/src/main/scala/cats/kernel/Order.scala	`81.08% <0%> (-5.41%)`	⬇️
core/src/main/scala/cats/Apply.scala	`84.21% <0%> (-4.68%)`	⬇️
laws/src/main/scala/cats/laws/discipline/Eq.scala	`90.9% <0%> (-2.2%)`	⬇️
...in/scala/cats/laws/discipline/CartesianTests.scala	`100% <0%> (ø)`	⬆️
...el/src/main/scala/cats/kernel/instances/unit.scala	`100% <0%> (ø)`	⬆️
...rc/main/scala/cats/kernel/instances/function.scala	`100% <0%> (ø)`	⬆️
...nel/src/main/scala/cats/kernel/instances/int.scala	`100% <0%> (ø)`	⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0997f43...fa520d7. Read the comment docs.

kailuowang · 2017-10-03T21:00:41Z

core/src/main/scala/cats/data/EitherT.scala

   * res1: cats.data.EitherT[Option,Nothing,Int] = EitherT(None)
   * }}}
   */
+  final def liftF[F[_], A, B](fb: F[B])(implicit F: Functor[F]): EitherT[F, A, B] = right(fb)
+
+  @deprecated("Use EitherT.liftF.", "1.0.0-MF")


Should this version be "1.0.0-RC1"?

kailuowang · 2017-10-03T21:07:08Z

All looking good. The scalafix should probably go to a different folder altogether. The current set of rules v1_0_0 is for migration from 0.9.0 to 1.0.0-MF, the one you add is from 1.0.0-MF to 1.0.0-RC. We can't merge this as is since it will cause problems when people trying to migrate to 1.0.0-MF. We need a new set of rules for such migration, maybe we can name it v1_0_0_RC1? cc @gabro

aeons · 2017-10-03T21:17:11Z

Aha, I just mimicked what was there already. Will take a look at fixing it tomorrow.

kailuowang · 2017-10-03T21:18:05Z

sorry @aeons it was supposed to be a super straightforward PR.

aeons · 2017-10-03T21:18:52Z

No problem, I don't mind trying out scalafix :)

gabro

👍 for the scalafix part.

kailuowang · 2017-10-04T14:14:06Z

scalafix/README.md

+If you only want to run the rules that apply to version `1.0.0-MF` run
+
+```sh
+sbt scalafix github:typelevel/cats/v1.0.0?sha=c131fe4


The 1.0.0 update on master has not much practical use now since it's not released, how about we reorder the paragraphs to this?

to run the rules that apply to version 1.0.0-MF run sbt scalafix github:typelevel/cats/v1.0.0?sha=c131fe4 to run all rules that apply to current 1.0.0-SNAPSHOT sbt scalafix github:typelevel/cats/v1.0.0

We can update it again once we release 1.0.0-RC1

Sounds good

kailuowang

Thanks very much! Sorry for dragging it for this long for a straightforward change.

LukaJCB · 2017-10-08T10:51:15Z

Thanks @aeons :) This is ready to be merged as soon as we merge #1937 I think 👍

aeons added 3 commits October 3, 2017 19:04

Rename EitherT.liftT to EitherT.liftF

aee6b39

To be consistent with OptionT.liftF.

Re-add liftT with a @deprecated notice

8b5df3f

Add scalafix rule for renaming EitherT.liftT

6395fdc

aeons force-pushed the eithert-liftf branch from 1fc4d89 to 6395fdc Compare October 3, 2017 17:04

LukaJCB previously approved these changes Oct 3, 2017

View reviewed changes

kailuowang reviewed Oct 3, 2017

View reviewed changes

aeons added 2 commits October 4, 2017 12:28

Set deprecated since to 1.0.0-RC1

6a5f81f

Update scalafix readme

e248c15

aeons dismissed LukaJCB’s stale review via e248c15 October 4, 2017 11:13

gabro approved these changes Oct 4, 2017

View reviewed changes

kailuowang reviewed Oct 4, 2017

View reviewed changes

Update scalafix readme

fa520d7

kailuowang approved these changes Oct 4, 2017

View reviewed changes

LukaJCB approved these changes Oct 8, 2017

View reviewed changes

LukaJCB merged commit 5f19814 into typelevel:master Oct 10, 2017

aeons deleted the eithert-liftf branch October 10, 2017 11:16

kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017

kailuowang added the Source Breaking label Oct 15, 2017

kailuowang added the enhancement label Dec 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename EitherT.liftT to EitherT.liftF #1947

Rename EitherT.liftT to EitherT.liftF #1947

aeons commented Oct 3, 2017

kailuowang commented Oct 3, 2017

aeons commented Oct 3, 2017 •

edited

Loading

LukaJCB commented Oct 3, 2017

kailuowang commented Oct 3, 2017

codecov-io commented Oct 3, 2017 •

edited

Loading

kailuowang Oct 3, 2017

kailuowang commented Oct 3, 2017

aeons commented Oct 3, 2017

kailuowang commented Oct 3, 2017

aeons commented Oct 3, 2017

gabro left a comment

kailuowang Oct 4, 2017

aeons Oct 4, 2017

kailuowang left a comment •

edited

Loading

LukaJCB commented Oct 8, 2017

Rename EitherT.liftT to EitherT.liftF #1947

Rename EitherT.liftT to EitherT.liftF #1947

Conversation

aeons commented Oct 3, 2017

kailuowang commented Oct 3, 2017

aeons commented Oct 3, 2017 • edited Loading

LukaJCB commented Oct 3, 2017

kailuowang commented Oct 3, 2017

codecov-io commented Oct 3, 2017 • edited Loading

Codecov Report

kailuowang Oct 3, 2017

Choose a reason for hiding this comment

kailuowang commented Oct 3, 2017

aeons commented Oct 3, 2017

kailuowang commented Oct 3, 2017

aeons commented Oct 3, 2017

gabro left a comment

Choose a reason for hiding this comment

kailuowang Oct 4, 2017

Choose a reason for hiding this comment

aeons Oct 4, 2017

Choose a reason for hiding this comment

kailuowang left a comment • edited Loading

Choose a reason for hiding this comment

LukaJCB commented Oct 8, 2017

aeons commented Oct 3, 2017 •

edited

Loading

codecov-io commented Oct 3, 2017 •

edited

Loading

kailuowang left a comment •

edited

Loading