New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OptionT.liftF and EitherT.liftT should be named the same #1945

Closed

aeons opened this issue Oct 3, 2017 · 0 comments

Member

aeons commented Oct 3, 2017

Shouldn't these two be named the same? I have no strong preference for either name, but would like them to be consistent.

object OptionT {
  def liftF[F[_], A](fa: F[A])(implicit F: Functor[F]): OptionT[F, A] = OptionT(F.map(fa)(Some(_)))
}
object EitherT {
  final def liftT[F[_], A, B](fb: F[B])(implicit F: Functor[F]): EitherT[F, A, B] = right(fb)
}

aeons mentioned this issue

Rename EitherT.liftT to EitherT.liftF #1947

Merged

LukaJCB closed this as completed in #1947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment