build: use curly braces for disabling tasks #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using parentheses for disabling tasks with sbt 1.0 will issue the
following deprecation warning:
```
warning: Adaptation of argument list by inserting () is deprecated: this
is unlikely to be what you want.
signature: DefinableTask.:=(v: S): sbt.Def.Setting[sbt.Task[S]]
given arguments: <none>
after adaptation: DefinableTask.:=((): Unit)
publish := (),
^
```
This can be fixed with curly braces which is also perfectly fine with
sbt 0.13. So this can be merged right now and will make the actual
upgrade to sbt 1.0 easier.
kailuowang
approved these changes
Aug 30, 2017
Codecov Report
@@ Coverage Diff @@
## master #1876 +/- ##
=======================================
Coverage 94.97% 94.97%
=======================================
Files 241 241
Lines 4195 4195
Branches 109 109
=======================================
Hits 3984 3984
Misses 211 211Continue to review full report at Codecov.
|
LukaJCB
pushed a commit
to LukaJCB/cats
that referenced
this pull request
Sep 1, 2017
Using parentheses for disabling tasks with sbt 1.0 will issue the
following deprecation warning:
```
warning: Adaptation of argument list by inserting () is deprecated: this
is unlikely to be what you want.
signature: DefinableTask.:=(v: S): sbt.Def.Setting[sbt.Task[S]]
given arguments: <none>
after adaptation: DefinableTask.:=((): Unit)
publish := (),
^
```
This can be fixed with curly braces which is also perfectly fine with
sbt 0.13. So this can be merged right now and will make the actual
upgrade to sbt 1.0 easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using parentheses for disabling tasks with sbt 1.0 will issue the
following deprecation warning:
This can be fixed with curly braces which is also perfectly fine with
sbt 0.13. So this can be merged right now and will make the actual
upgrade to sbt 1.0 easier.