Skip to content

Commit

Permalink
build: use curly braces for disabling tasks (#1876)
Browse files Browse the repository at this point in the history
Using parentheses for disabling tasks with sbt 1.0 will issue the
following deprecation warning:
```
warning: Adaptation of argument list by inserting () is deprecated: this
is unlikely to be what you want.
        signature: DefinableTask.:=(v: S): sbt.Def.Setting[sbt.Task[S]]
  given arguments: <none>
 after adaptation: DefinableTask.:=((): Unit)
  publish := (),
          ^
```

This can be fixed with curly braces which is also perfectly fine with
sbt 0.13. So this can be merged right now and will make the actual
upgrade to sbt 1.0 easier.
  • Loading branch information
fthomas authored and kailuowang committed Aug 30, 2017
1 parent 260171d commit 52457d2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -464,8 +464,8 @@ addCommandAlias("validate", ";clean;validateJS;validateKernelJS;validateFreeJS;v
addCommandAlias("gitSnapshots", ";set version in ThisBuild := git.gitDescribedVersion.value.get + \"-SNAPSHOT\"")

lazy val noPublishSettings = Seq(
publish := (),
publishLocal := (),
publish := {},
publishLocal := {},
publishArtifact := false
)

Expand Down

0 comments on commit 52457d2

Please sign in to comment.