Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polling system #3332

Merged
merged 104 commits into from
Jun 13, 2023
Merged

Polling system #3332

merged 104 commits into from
Jun 13, 2023

Conversation

armanbilge
Copy link
Member

@armanbilge armanbilge commented Dec 26, 2022 •
edited
Loading

djspiewak and others added 30 commits November 24, 2022 12:22
@djspiewak
Initial sketch of PollingSystem
6a21e49
@armanbilge
Iterate polling system sketch
cca9caf
@armanbilge
Extract PollingSystem abstraction on Native
6d23310
@armanbilge
Add FileDescriptorPoller abstraction
727bfe8
@armanbilge @LeeTibbert
Add EpollSystem and KqueueSystem
9a8f7ed 
Co-authored-by: Lee Tibbert <lee.tibbert@gmail.com>
@armanbilge
Add test for Scheduler#sleep
0889426
@armanbilge @lolgab
Add FileDescriptorPollerSpec
4250049 
Co-authored-by: Lorenzo Gabriele <lorenzolespaul@gmail.com>
@armanbilge
Consistent error-handling in KqueueSystem
0b9ac02
@armanbilge
Make pollingSystem configurable in IOApp
956734a
@armanbilge
Nowarn unuseds
dda54b7
@armanbilge
Revise the fd poller spec
1206b27
@armanbilge
Remove maxEvents config from EpollSystem
e0c4ec3
@armanbilge
Remove maxEvents config from KqueueSystem
eeeb3e6
@armanbilge
Add test for many simultaneous events
c4a0a16
@armanbilge
Remove redundant final
aae6e97
@armanbilge
Update comment
457f89c
@armanbilge
Add test for pre-existing readiness
721c2fc
@armanbilge
Add test for no readiness
4f9e57b
@armanbilge
Reimagine FileDescriptorPoller
a520aee
@armanbilge
Fix parameter names
5f8146b
@armanbilge
Refactor/redesign PollingSystem ... again ... (:
3640605
@armanbilge
Dump EventLoop abstraction
42491da
@armanbilge
Update the FileDescriptorPollerSpec
786127c
@armanbilge
Rework EpollSystem
de3eea0
@armanbilge
Set pipes to non-blocking mode
eb8ba84
@armanbilge
Add fcntl import
0124567
@armanbilge
Fix bugs in spec
72b05a7
@armanbilge
Add some uncancelables
d18fa76
@armanbilge
Revert "Add some uncancelables"
4d3a916 
This reverts commit d18fa76.
@armanbilge
Rework KqueueSystem
9ba870f
@armanbilge
Copy link
Member Author

Daniel and I discussed on Discord earlier today. Our working plan is to merge this PR into series/3.x more-or-less as-is, very soon. Then we will continue revising as follow-up PRs, particularly the encoding. The hope is that this strategy will make it easier to collaborate :)

This was referenced Jun 13, 2023
Closed
Open
Open
Closed
@armanbilge armanbilge merged commit e9aeb8c into typelevel:series/3.x Jun 13, 2023
@armanbilge
Copy link
Member Author

I published 3.6-e9aeb8c. I'll work on updating my FS2 PR next and then publish a snapshot of that as well. Together that should be sufficient for testing Ember.

@armanbilge armanbilge mentioned this pull request Jun 14, 2023
Open
8 tasks
@armanbilge
Copy link
Member Author

I published FS2 3.8-1580d81. Anyone should be able to try this today with http4s Ember, Skunk, etc.

This was referenced Jun 14, 2023
Closed
Draft
Draft
@armanbilge armanbilge mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djspiewak djspiewak djspiewak left review comments

Assignees
No one assigned
Labels
🔬 experiment 🍄 enhancement
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@armanbilge @wjoel @djspiewak @durban @TonioGela