Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOPify the PollingSystem encoding #3683

Closed
armanbilge opened this issue Jun 13, 2023 · 1 comment
Closed

OOPify the PollingSystem encoding #3683

armanbilge opened this issue Jun 13, 2023 · 1 comment
Milestone

Comments

@armanbilge
Copy link
Member

Well, Daniel wants us to anyway 😝 for some reason I'm not crazy about this idea, but I won't die on this hill.

Basically, we should make an abstract class Poller or something, and move these methods onto that.

def closePoller(poller: Poller): Unit
/**
* @param nanos
* the maximum duration for which to block, where `nanos == -1` indicates to block
* indefinitely.
*
* @return
* whether any events were polled
*/
def poll(poller: Poller, nanos: Long, reportFailure: Throwable => Unit): Boolean
/**
* @return
* whether poll should be called again (i.e., there are more events to be polled)
*/
def needsPoll(poller: Poller): Boolean
def interrupt(targetThread: Thread, targetPoller: Poller): Unit

Follow-up to:

@armanbilge armanbilge added this to the v3.6.0 milestone Jun 13, 2023
@djspiewak
Copy link
Member

Wontfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants