Handle Windows line endings correctly in inline templates #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #224.
Today I learned that, according to the ECMAScript spec, when the sequence
\r\n
(not the escapes, but the actual characters they represent) appears in the contents of a template string, they're normalized to be treated the same as a single\n
.Babel honors this, causing template strings parsed from files using Windows line endings to be "missing" their
\r
s in the value their AST node contains. This, in turn, meant we were getting off-by-n
errors in inline templates, wheren
was the number of lines into the template we were looking at any given time.To avoid this problem, when we deal with embedded templates, we now determine their contents by slicing them directly from the original source text instead of retrieving their parsed
value
from theTemplateElement
node.